ci: improve github workflows #1460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
changed the title
Centralise the CI in main.yml making it easier for contributors to understand the requirements avoid them to view non-standard script files. Fix detection of new files so that broken changes are detected by CI. Eliminate duplicate test run to reduce the time needed to run. Add check for go mod tidy to ensure that go mod is clean before it's allowed to be merged. Update to action/setup-go@v4 which enables caching by default improving the performance of all workflows.
stevenh
force-pushed
the
ci/eliminate-scripts
branch
from
ba2ff69
to
83b38eb
Compare
alexandear
reviewed
Aug 22, 2023
| run: | | ||
| go mod tidy | ||
| (cd _codegen && go mod tidy) | ||
| git --no-pager diff && [[ -z $(git status -s) ]] |
There was a problem hiding this comment.
We can use --exit-code parameter here and below:
Suggested change
| git --no-pager diff && [[ -z $(git status -s) ]] | |
| git --no-pager diff --exit-code |
There was a problem hiding this comment.
That wouldn't handle the case where there are new files generated unfortunately., which is what git status -s catches.
alexandear
approved these changes
Aug 22, 2023
|
The separate scripts allow the maintainers and the contributor to run the checks offline on their local machine without depending on GitHub Actions. This is a feature, not a bug! GitHub Action checkout v4 is already #1408. Please review it. |
|
Please split this MR in multiple ones:
Also drop the merge of |
dolmen
added
github_actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Centralise the CI in GitHub workflow, fix detection missing changes and improve performance.
Changes
main.ymlaction/setup-go@v4Motivation
Make it easier for contributors to understand the requirements by avoiding them having to view and understand non-standard script files.
Ensure that missing changes / clean are detected before merges, to improve quality.
Speed up actions by removing duplicate actions and using caching.