Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "assert: ObjectsAreEqual: use time.Equal for time.Time type" #1537

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Revert "assert: ObjectsAreEqual: use time.Equal for time.Time type" #1537

merged 1 commit into from
Feb 19, 2024

Commits on Feb 18, 2024

  1. Revert "assert: ObjectsAreEqual: use time.Equal for time.Time type" 

    This reverts commit 34763e0.

time.Time.Equal only tests that the two instances refer to the same instant, but time.Time also carries zone information, so this caused two non-equal instances to be considered equal.
    @brackendawson
    brackendawson committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    7b3de08 View commit details
    Browse the repository at this point in the history