Adapt EqualExportedValues to accept ptr types on top of struct types #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually there's another PR doing this: #1517 |
redachl
deleted the
fix/assert-equal-exported-values-accepts-pointers-too
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: This is my first pull request on an open-source project.
Summary
This PR adapts the
EqualExportedValuesmethod to also handle pointer types, on top of struct types.Changes
The function
copyExportedFieldsalready handles pointer types correctly. Therefore it is only necessary to make the validation include pointer types.The added tests pass, which validates this hypothesis.
Motivation
It is useful for proto message equality. Using
Equaloften fails because unexported values of proto messages are different.Related issues
Closes #758