Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_assertions: honour the msgAndArgs provided with each assertion #1548

Merged
merged 4 commits into from
Feb 23, 2024
Merged

http_assertions: honour the msgAndArgs provided with each assertion #1548

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecdde72
http_assertions: honour the msgAndArgs provided with each assertion
arjunmahishi Feb 22, 2024
135b468
assert: honour the msgAndArgs provided in InEpsilon
arjunmahishi Feb 22, 2024
840f800
http_assertions: Include msgAndArgs is some of the existing tests
arjunmahishi Feb 23, 2024
6e59f20
http_assertions: assert that the msgAndArgs actually works in tests
arjunmahishi Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 20 additions & 5 deletions assert/http_assertions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ func TestHTTPSuccess(t *testing.T) {
assert.True(mockT2.Failed())

mockT3 := new(testing.T)
assert.Equal(HTTPSuccess(mockT3, httpError, "GET", "/", nil), false)
assert.Equal(HTTPSuccess(
mockT3, httpError, "GET", "/", nil,
"was not expecting a failure here",
), false)
arjunmahishi marked this conversation as resolved.
Show resolved Hide resolved
assert.True(mockT3.Failed())

mockT4 := new(testing.T)
Expand All @@ -58,7 +61,10 @@ func TestHTTPRedirect(t *testing.T) {
assert := New(t)

mockT1 := new(testing.T)
assert.Equal(HTTPRedirect(mockT1, httpOK, "GET", "/", nil), false)
assert.Equal(HTTPRedirect(
mockT1, httpOK, "GET", "/", nil,
"was expecting a 3xx status code. Got 200.",
), false)
assert.True(mockT1.Failed())

mockT2 := new(testing.T)
Expand All @@ -82,7 +88,10 @@ func TestHTTPError(t *testing.T) {
assert.True(mockT1.Failed())

mockT2 := new(testing.T)
assert.Equal(HTTPError(mockT2, httpRedirect, "GET", "/", nil), false)
assert.Equal(HTTPError(
mockT2, httpRedirect, "GET", "/", nil,
"Expected this request to error out. But it didn't",
), false)
assert.True(mockT2.Failed())

mockT3 := new(testing.T)
Expand All @@ -106,7 +115,10 @@ func TestHTTPStatusCode(t *testing.T) {
assert.True(mockT2.Failed())

mockT3 := new(testing.T)
assert.Equal(HTTPStatusCode(mockT3, httpError, "GET", "/", nil, http.StatusSwitchingProtocols), false)
assert.Equal(HTTPStatusCode(
mockT3, httpError, "GET", "/", nil, http.StatusSwitchingProtocols,
"Expected the status code to be %d", http.StatusSwitchingProtocols,
), false)
assert.True(mockT3.Failed())

mockT4 := new(testing.T)
Expand Down Expand Up @@ -174,7 +186,10 @@ func TestHttpBody(t *testing.T) {
assert.False(HTTPBodyContains(mockT, httpHelloName, "GET", "/", url.Values{"name": []string{"World"}}, "world"))

assert.False(HTTPBodyNotContains(mockT, httpHelloName, "GET", "/", url.Values{"name": []string{"World"}}, "Hello, World!"))
assert.False(HTTPBodyNotContains(mockT, httpHelloName, "GET", "/", url.Values{"name": []string{"World"}}, "World"))
assert.False(HTTPBodyNotContains(
mockT, httpHelloName, "GET", "/", url.Values{"name": []string{"World"}}, "World",
"Expected the request body to not contain 'World'. But it did.",
))
assert.True(HTTPBodyNotContains(mockT, httpHelloName, "GET", "/", url.Values{"name": []string{"World"}}, "world"))

assert.True(HTTPBodyContains(mockT, httpReadBody, "GET", "/", nil, "hello"))
Expand Down