Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: downgrade objx to v0.5.1 #1561

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dolmen
Copy link
Collaborator

@dolmen dolmen commented Mar 4, 2024

Summary

objx v0.5.2 unnecessarly upgrades the minimum Go version from 1.13 to 1.20. v0.5.1 is just enough.

Changes

Motivation

objx v0.5.1 is just enough. But stretchr/objx#149 changed the minimum Go version from 1.13 to 1.20.

We don't want to force users to upgrade Go to use the latest testify version while we don't use specific features of those later versions.

Related issues

Revert #1552.
See stretchr/objx#149.

This reverts commit 814075f.

objx v0.5.2 unnecessarly upgrades the minimum Go version from 1.13 to 1.20.
@brackendawson
Copy link
Collaborator

brackendawson commented Mar 4, 2024

v1.17 builds all passed, what is the actual minimum version this imposed on users?

Copy link
Collaborator

@brackendawson brackendawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is not necessary.

Because a go directive before 1.21 is advisory and objx set it to 1.20 (for no reason), it is not possible for the configuration in v1.9.0 to generate an error. Testify's advisory 1.17 takes precedence, for what that is worth.

If objx set it to 1.22, then 1.21 toolchains would refuse to import testify v1.9.0 and our oldstable and 1.21 builds would have failed. This would be a good reason to keep every version between 1.17 and stable in our tests.

@dolmen dolmen added the dependencies Pull requests that update a dependency file label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants