Release lock before .WaitUntil #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng parallel objects. Address stretchr#167: Unable to test concurrent objects
|
@anpez could you add a test so we avoid regressions in the future? |
Agree |
|
@anpez small nudge, the tests from this PR are not passing :) |
|
Fixed it! Looks like since I wrote it, some code around it changed :) |
| }() | ||
|
|
||
| // Allow the first call to execute, so the second one executes afterwards | ||
| ch2 <- time.Now() |
There was a problem hiding this comment.
Maybe it would be good to have each go func() write something and assert the order is correct at the end of the test?
jonnyreeves
pushed a commit
to jonnyreeves/testify
that referenced
this pull request
Jan 5, 2017
Release lock before .WaitUntil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release the lock before .WaitUntil prevents deadlocks when testing parallel objects.
Address #167: Unable to test concurrent objects