When diffing with spew, use a format that doesn't include pointer addresses #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atombender
force-pushed
the
remove_addresses_from_diff
branch
from
836afd7
to
dd66125
Compare
…resses (which generate false negatives). This updates go-spew to 04cdfd42973bb9c8589fd6a731800cf222fde1a9.
atombender
force-pushed
the
remove_addresses_from_diff
branch
from
dd66125
to
cbd71e7
Compare
|
@atombender thanks! Sorry it took a few days to review, but I'm travelling a lot right now. I'm merging it now. Do you want to tackle an option to always return a trailing comma in Spew too? it would fix #288 and make the diffing even better :) Thanks again! |
|
Awesome, thanks, @ernesto-jimenez. I hadn't though about the comma problem, but sure, I can take a look at that. |
jonnyreeves
pushed a commit
to jonnyreeves/testify
that referenced
this pull request
Jan 5, 2017
…_diff When diffing with spew, use a format that doesn't include pointer addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When diffing with spew, use a format that doesn't include pointer addresses (which generate false negatives).
This updates go-spew to 04cdfd42973bb9c8589fd6a731800cf222fde1a9.
This fixes #317.