Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert.Eventually: fail the testcase if condition is not met #869

Merged
merged 1 commit into from
Jan 28, 2020
Merged

assert.Eventually: fail the testcase if condition is not met #869

merged 1 commit into from
Jan 28, 2020

Conversation

torkelrogstad
Copy link
Contributor

Fixes #837
This PR is a rebased version of #838

@boyan-soubachov boyan-soubachov merged commit ce22928 into stretchr:master Jan 28, 2020
@torkelrogstad torkelrogstad mentioned this pull request Jan 29, 2020
Closed
@dgzlopes dgzlopes mentioned this pull request Mar 1, 2020
Merged
@dolmen dolmen mentioned this pull request Jul 6, 2023
Merged
@dolmen dolmen added bug pkg-assert Change related to package testify/assert assert.Eventually About assert.Eventually/EventuallyWithT labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyan-soubachov boyan-soubachov boyan-soubachov approved these changes

@glesica glesica Awaiting requested review from glesica

Assignees
No one assigned
Labels
assert.Eventually About assert.Eventually/EventuallyWithT bug pkg-assert Change related to package testify/assert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assert.Eventually() does not fail test when the timer expires
4 participants
@torkelrogstad @boyan-soubachov @dolmen @dmacvicar