Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional printer columns to KafkaAccess #61

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

MichaelMorrisEst
Copy link
Contributor

This PR adds the following additional printer columns to KafkaAccess:

  • listener
  • cluster
  • user

For example:

NAME              LISTENER   CLUSTER      USER
my-kafka-access   tls        my-cluster   my-user

Partially addresses #53

Signed-off-by: MichaelMorris <michael.morris@est.tech>
@scholzj scholzj requested a review from katheris October 15, 2024 12:10
@scholzj scholzj added this to the 0.2.0 milestone Oct 15, 2024
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, LGTM otherwise, thanks.

Signed-off-by: MichaelMorris <michael.morris@est.tech>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MichaelMorrisEst, LGTM

@katheris katheris merged commit 5eb20e6 into strimzi:main Oct 16, 2024
11 checks passed
scholzj pushed a commit that referenced this pull request Feb 2, 2025
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants