Refactor maven-assembly-plugin so no uber jar is created. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen <owencorrigan76@gmail.com>
OwenCorrigan76
force-pushed
the
assembly-descriptor-issue
branch
from
0218bcf
to
16fb9cd
Compare
scholzj
approved these changes
Jun 27, 2024
README.md
Outdated
| @@ -9,7 +9,7 @@ The implementation is currently still in progress. | |||
| ## Build | |||
|
|
|||
| ```shell | |||
| mvn package assembly:single | |||
| mvn package | |||
There was a problem hiding this comment.
Suggested change
| mvn package | |
| mvn package |
Signed-off-by: Owen <owencorrigan76@gmail.com>
scholzj
approved these changes
Jun 27, 2024
mimaison
approved these changes
Jun 27, 2024
This was referenced Jun 27, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to deal with the following issue #24.
Previously,
metrics-reporter-1.0.0-SNAPSHOT-jar-with-dependencies.jarwas created withmaven-assembly-plugin. To keep in line with other Strimzi projects, it was decided to create a dist.xml file and then normally produce the regular JARs and if needed a ZIP / TGZ archive with all the required dependencies.