[ST] Remove NodePort from the 'weird username tests' for Kafka Bridge #10384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
henryZrncik
approved these changes
Jul 25, 2024
systemtest/src/test/java/io/strimzi/systemtest/bridge/HttpBridgeTlsST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/bridge/HttpBridgeTlsST.java
Outdated
Show resolved
Hide resolved
Frawless
approved these changes
Jul 25, 2024
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
In the past, there was no way how to write "weird username" tests with our internal clients, as they used the Kafka scripts for the producer/consumer, which had limitation in the length of the user name - which is the main part of this test -> testing that everything works with some special characters and longer names. In the external clients (which are just our implementation of the Java Kafka clients) there is not such limitation -> that's why we used them. But after the creation of
test-clients, there is not such limitation as well. So in the tests it is not needed to keep the external clients.This PR removes the NodePort from the "weird username tests" for the Kafka Bridge. Together with that, I'm moving the tests into the
HttpBridgeTlsclass, because the "external listener" is not a thing after the changes, so the extra class is not needed.Fixes #7608
Checklist