Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate storage class overrides #10407

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Aug 1, 2024

Type of change

  • Task

Description

This PR deprecates the storage class overrides in storage configuration as approved in Strimzi Proposal no. 80. It also updates the documentation accordingly. The warnings when the overrides are used are issued automatically for the deprecations. So there is no special code or test for them.

Checklist

  • Update documentation
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Update CHANGELOG.md

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.43.0 milestone Aug 1, 2024
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I left a few suggestions.

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj
Copy link
Member Author

scholzj commented Aug 3, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scholzj scholzj merged commit 9d8941e into strimzi:main Aug 5, 2024
21 checks passed
@scholzj scholzj deleted the deprecate-storage-overrides branch August 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants