Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 10016 Allow KafkaRoller talk to controller directly #11132

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

tinaselenge
Copy link
Contributor

Type of change

Select the type of your PR

  • Bugfix

Description

This reverts commit 1f1a16d.

This is because of the issue reported in KAFKA-18230, admin requests for quorum info fail if the active controller has changed and admin does not update its metadata and retry.
This causes errors in the operator, not able to reconcile Kafka nodes until the metadata is eventually refreshed at some point. This issue is fixed in Kafka 4.0.
Once only 4.0 and later versions are supported, this change will be re-implemented.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

This reverts commit 1f1a16d.

This is because of the issue reported in KAFKA-18230,
admin requests for quorum info fail if the active controller has changed
and admin does not update its metadata and retry.
This causes errors in the operator, not able to reconcile Kafka nodes
until the metadata is eventually refreshed at some point.
This issue is fixed in Kafka 4.0.
Once only 4.0 and later versions are supported, this change will be re-implemented.

Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
@ppatierno
Copy link
Member

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member

scholzj commented Feb 12, 2025

/azp run upgrade

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj requested a review from ppatierno February 12, 2025 16:49
@scholzj scholzj merged commit 2040e08 into strimzi:main Feb 13, 2025
25 checks passed
@tinaselenge tinaselenge deleted the revert-10016 branch February 14, 2025 12:24
tinaselenge added a commit to tinaselenge/strimzi-kafka-operator that referenced this pull request Feb 17, 2025
…i#11132)

Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants