Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe add confirm() to the "Mark all as read" button? #481

Open
naps62 opened this issue Apr 2, 2018 · 9 comments
Open

Maybe add confirm() to the "Mark all as read" button? #481

naps62 opened this issue Apr 2, 2018 · 9 comments

Comments

@naps62
Copy link
Contributor

naps62 commented Apr 2, 2018

I accidentally clicked "Mark as all read" instead of the "Refresh" button, causing all my unread entries to disapear.

This looks like a UI problem to me. The button is not really clear on it's purpose since there's only an icon (and a title attribute, but that only shows up if you hover it for a second).

Since it's such a no-turning-back action, I would say there should be some confirmation here

@vcavallo
Copy link

Thumbs-downs should explain themselves. Thumbs-ups are self-explanatory.

@naps62 naps62 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2023
@guidopetri
Copy link
Collaborator

@naps62 sorry, reopening - I think this is a very useful feature

@guidopetri guidopetri reopened this Nov 26, 2023
@naps62 naps62 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2023
@guidopetri
Copy link
Collaborator

Okay... I opened a new issue then :s

@vcavallo
Copy link

vcavallo commented Nov 26, 2023 via email

@naps62
Copy link
Contributor Author

naps62 commented Nov 26, 2023

@guidopetri sorry 😅 I was going through my own stale issues (3+ years old), and I guess you re-opened in between and made it into my list as I was still scrolling

@naps62 naps62 reopened this Nov 26, 2023
@guidopetri
Copy link
Collaborator

Gotcha, I'll close the duplicated issue then 😅

@naps62
Copy link
Contributor Author

naps62 commented Nov 26, 2023

btw, glad at least my cleanup was productive for popping up some old issue 😄
I no longer use stringer, but really like the concept. glad to see it's still kicking

@guidopetri
Copy link
Collaborator

Just confirming here that we really need this. I accidentally pressed Shift + A and marked everything read on my instance just now.

@mockdeep
Copy link
Collaborator

mockdeep commented Sep 8, 2024

I think we probably need to set up turbo with a data-turbo-confirm for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants