register all elements (#519)

stripe-archive · Apr 21, 2020 · 809258a · 809258a
1 parent bcd8f80
commit 809258a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/src/components/Element.js b/src/components/Element.js
@@ -79,18 +79,12 @@ const Element = (
         element.mount(this._ref);
 
         // Register Element for automatic token / source / paymentMethod creation
-        if (
-          hocOptions.impliedTokenType ||
-          hocOptions.impliedSourceType ||
+        this.context.registerElement(
+          element,
+          hocOptions.impliedTokenType,
+          hocOptions.impliedSourceType,
           hocOptions.impliedPaymentMethodType
-        ) {
-          this.context.registerElement(
-            element,
-            hocOptions.impliedTokenType,
-            hocOptions.impliedSourceType,
-            hocOptions.impliedPaymentMethodType
-          );
-        }
+        );
       });
     }
 

diff --git a/src/components/Element.test.js b/src/components/Element.test.js
@@ -73,11 +73,17 @@ describe('Element', () => {
     expect(context.unregisterElement).toHaveBeenCalledWith(elementMock);
   });
 
-  it('should call the right hooks for a non-registered Element', () => {
+  it('should call the right hooks for a non-auto-detected Element', () => {
     const TestElement = Element('test');
     const element = mount(<TestElement onChange={jest.fn()} />, {context});
 
-    expect(context.registerElement).toHaveBeenCalledTimes(0);
+    expect(context.registerElement).toHaveBeenCalledTimes(1);
+    expect(context.registerElement).toHaveBeenCalledWith(
+      elementMock,
+      undefined,
+      undefined,
+      undefined
+    );
 
     element.unmount();
     expect(elementMock.destroy).toHaveBeenCalledTimes(1);