Add test to AddressElement

stripe · Nov 11, 2024 · 3b92d5b · 3b92d5b
1 parent d4d7f50
commit 3b92d5b
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 6 deletions.
diff --git a/payments-ui-core/src/test/java/com/stripe/android/ui/core/elements/AddressElementTest.kt b/payments-ui-core/src/test/java/com/stripe/android/ui/core/elements/AddressElementTest.kt
@@ -495,6 +495,33 @@ class AddressElementTest {
         assertThat(country()).isEqualTo("US")
     }
 
+    @Test
+    fun `when phone number is required, should not be complete until fully entered`() = runTest {
+        val addressElement = AddressElement(
+            IdentifierSpec.Generic("address"),
+            mapOf(
+                IdentifierSpec.Country to "CA"
+            ),
+            countryDropdownFieldController = countryDropdownFieldController,
+            addressType = AddressType.Normal(
+                phoneNumberState = PhoneNumberState.REQUIRED
+            ),
+            sameAsShippingElement = null,
+            shippingValuesMap = null,
+        )
+
+        val phoneNumberController = addressElement.phoneNumberElement.controller
+
+        phoneNumberController.onRawValueChange("123")
+        assertThat(phoneNumberController.isComplete.value).isFalse()
+
+        phoneNumberController.onRawValueChange("123456")
+        assertThat(phoneNumberController.isComplete.value).isFalse()
+
+        phoneNumberController.onRawValueChange("1234567890")
+        assertThat(phoneNumberController.isComplete.value).isTrue()
+    }
+
     private fun createAddressElement(initialValues: Map<IdentifierSpec, String>): AddressElement {
         return AddressElement(
             IdentifierSpec.Generic("address"),

diff --git a/...e/android/paymentsheet/example/samples/ui/addresselement/AddressElementExampleActivity.kt b/...e/android/paymentsheet/example/samples/ui/addresselement/AddressElementExampleActivity.kt
@@ -57,12 +57,6 @@ class AddressElementExampleActivity : AppCompatActivity() {
                         Button(
                             onClick = {
                                 val config = AddressLauncher.Configuration.Builder()
-                                    .additionalFields(
-                                        additionalFields = AddressLauncher.AdditionalFieldsConfiguration(
-                                            phone = AddressLauncher.AdditionalFieldsConfiguration
-                                                .FieldConfiguration.REQUIRED
-                                        )
-                                    )
                                     // Provide your Google Places API key to enable autocomplete
                                     .googlePlacesApiKey(Settings(context).googlePlacesApiKey)
                                     .build()