Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardParams cannot be created with values provided by us #2893

Closed
droidluv opened this issue Sep 24, 2020 · 3 comments · Fixed by #2894
Closed

CardParams cannot be created with values provided by us #2893

droidluv opened this issue Sep 24, 2020 · 3 comments · Fixed by #2894
Assignees
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@droidluv
Copy link

droidluv commented Sep 24, 2020

In 16.0.0 CardParams cannot be created with values from our own custom UI like how we used to build a card with Card.Builder(), CardParams uses an internal constructor and most of the validation on the params that could be done on the Card object is deprecated.

We are forced to use the CardInputWidget to obtain the cardparams data is this an intentional move?, is there any new way to create a card token without relying on any of the Stripe UI components?, in 15.0.0 how this worked was we created a card object to pass to the create token function, now createToken for card is deprecated and we need to pass a CardParams object, and CardParams can only be obtained from the CardInputWidget and there is seemingly no way to feed data to CardParams or get it verified separately through convenience functions

@mshafrir-stripe
Copy link
Collaborator

@droidluv thanks for filing. I see that CardParams's constructors are internal, which is unintentional. I'll have this fixed and issue a new release as soon as we can.

Additionally, what methods were using previously that are no longer available? If you could share a code example that would be very helpful.

@mshafrir-stripe mshafrir-stripe self-assigned this Sep 24, 2020
@mshafrir-stripe mshafrir-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Sep 24, 2020
mshafrir-stripe added a commit that referenced this issue Sep 24, 2020
@gunjot-mansa
Copy link

gunjot-mansa commented Sep 27, 2020

Do anyone have any idea, when 16.1.0 is going to be released? I need this fix.

@amrishkakadiya
Copy link

Do anyone have any idea, when 16.1.0 is going to be released? I need this fix.

Already released and, its working with new version, I have tested with 16.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants