Add support for Diners Club 16 #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary
- Add `CardBrand.DinersClub16` to represent 16-digit Diners Club cards
- Update Diners Club BIN range
- Card numbers starting with `"30"`, `"38"`, or `"39"` represent
16-digit Diners Club cards
- Card numbers starting with `"36"` represent
14-digit Diners Club cards
- Update most tests to use `CardNumberFixtures`
Testing
Add unit tests
- Rename `maxLengthWithoutSpaces` to `defaultMaxLength` - Rename `maxLengthWithSpaces` to `defaultMaxLengthWithSpaces` - Create `getMaxLengthForCardNumber()` and `getMaxLengthWithSpacesForCardNumber()` to determine the max length based on the card number's prefix
Update max length whenever brand changes
davidme-stripe
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CardBrandCardBrand.DinersClubto support 16-digit Diners Club cards"30","38", or"39"represent 16-digit Diners Club cards"36"represent 14-digit Diners Club cardsmaxLengthWithoutSpacestodefaultMaxLengthmaxLengthWithSpacestodefaultMaxLengthWithSpacesgetMaxLengthForCardNumber()andgetMaxLengthWithSpacesForCardNumber()to determine the max length based on the card number's prefixCardNumberFixturesMotivation
Fixes #2205
Testing
Add unit tests