Change CardInputWidget icon to represent validity of input #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary After validating `CardInputWidget` input (i.e. when a params object is attempted to be created), if validation fails, show an error icon for the brand icon. Motivation Testing Unit test Manual validation
markfi-stripe
approved these changes
Feb 26, 2020
stripe-ci
assigned mshafrir-stripe and unassigned csabol-stripe, davidme-stripe and markfi-stripe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After validating
CardInputWidgetinput (i.e. when a params object isattempted to be created), if validation fails, show an error icon for
the brand icon.
Motivation
Previously, error state was only visually indicated by changing the text color of the fields. For some users, it is difficult or impossible to distinguish solely on color.
Fixes #2200
Testing
Unit test
Manual validation