Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML select option rendering in WebView #2657

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

mshafrir-stripe
Copy link
Collaborator

@mshafrir-stripe mshafrir-stripe commented Jul 27, 2020

Summary

appcompat:1.1.0 introduced an issue that caused WebViews on API 21
and 22 to crash on creation. There was a known fix for this issue,
but that fix broke rendering of HTML select options. This was because
the fix made the WebView use an Application context instead of
Activity context; Activity context is required to correctly render
HTML select options.

Upgrade to appcompat:1.2.0-rc02 and remove the fix.

See https://issuetracker.google.com/issues/141132133 for more details.

Motivation

Fixes #2656

Testing

Manually verified that WebViews render correctly after upgrading to
appcompat:1.2.0-rc02 and removing the crash workaround.

Manually verified that HTML select options now render correctly when
clicked.

select

Summary
`appcompat:1.1.0` introduced an issue that caused WebViews on API 21
and 22 to crash on creation. There was a known fix for this issue,
but that fix broke rendering of HTML select options. This was because
the fix made the `WebView` use an `Application` context instead of
`Activity` context; `Activity` context is required to correctly render
HTML select options.

Upgrade to `appcompat:1.2.0-rc02` and remove the fix.

See https://issuetracker.google.com/issues/141132133 for more details.

Motivation
Fixes #2656

Testing
Manually verified that WebViews render correctly after upgrading to
`appcompat:1.2.0-rc02` and removing the crash workaround.

Manually verified that HTML select options now render correctly when
clicked.
@mshafrir-stripe mshafrir-stripe merged commit 1f8f2fa into master Jul 28, 2020
@mshafrir-stripe mshafrir-stripe deleted the fix-select-options-rendering branch July 28, 2020 13:45
@vlad-roid
Copy link
Contributor

After finding out that users weren't able to change the app language in my apps anymore, I wasted 2 hours to backtrack it to coming from a patch Stripe version update from 15.0.0 to 15.0.1, which increases AppCompat 1.1.0 to a 1.2.0 minor version release candidate, without mentioning this anywhere in the release notes.

Please always list all library updates in your change logs

@mshafrir-stripe
Copy link
Collaborator Author

@vlad-roid I'm sorry for your time and effort that was spent due to the undocumented change. We will do our best to call out dependency upgrades. FYI we are upgrading to appcompat 1.2.0 for the upcoming release (see #2693).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FPX Account Selection Issue (Urgent)
5 participants