Fix HTML select option rendering in WebView #2657
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
appcompat:1.1.0
introduced an issue that caused WebViews on API 21and 22 to crash on creation. There was a known fix for this issue,
but that fix broke rendering of HTML select options. This was because
the fix made the
WebView
use anApplication
context instead ofActivity
context;Activity
context is required to correctly renderHTML select options.
Upgrade to
appcompat:1.2.0-rc02
and remove the fix.See https://issuetracker.google.com/issues/141132133 for more details.
Motivation
Fixes #2656
Testing
Manually verified that WebViews render correctly after upgrading to
appcompat:1.2.0-rc02
and removing the crash workaround.Manually verified that HTML select options now render correctly when
clicked.