[FC] Reload Auth Session instead of entire PartnerAuth Pane on cancellations #6837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmuvi-stripe
changed the title
carlosmuvi-stripe
requested review from
awush-stripe,
jameswoo-stripe and
tillh-stripe
and removed request for
awush-stripe
jameswoo-stripe
approved these changes
Jun 8, 2023
carlosmuvi-stripe
deleted the
carlosmuvi/BANKCON-7103/fc-reload-auth-session-instead-of-entire-partnerau
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue: When cancelling an AuthSession (ie. closing the browser while authenticating) we:
On these situations Android creates two AuthSessions, one in 2. and another one when reloading in 3.
This PR updates the code to what iOS does - creating a new auth session but staying in the pane.
Motivation
https://jira.corp.stripe.com/browse/BANKCON-7103
Testing