-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AmazonPay as a new payment method to Android PaymentSheet #7199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Small note about the release notes and the ignored test.
"async": false, | ||
"selector_icon": { | ||
"light_theme_png": "https://js.stripe.com/v3/fingerprinted/img/payment-methods/icon-pm-amazonpay_light-96e2ad49ffa7c7536dec91adaf68e898.png", | ||
"light_theme_svg": "https://js.stripe.com/v3/fingerprinted/img/payment-methods/icon-pm-amazonpay_light-711d254c9501ae4678f0046e7bb5e615.svg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: We could remove the SVG part, because we only use the PNGs on Android.
merchantCountryCode = "US", | ||
) | ||
|
||
@Ignore("Complex authorization handling required") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should figure this out before we merge this. Happy to help with that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I noticed that the issue is in the Web view. Is this something that will be fixed in the near future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about that, it will be updated to Amazon's own page once they start to build it out, so I marked it as ignored for now
Diffuse output:
APK
DEX
ARSC
|
CHANGELOG.md
Outdated
@@ -5,6 +5,7 @@ | |||
### PaymentSheet | |||
* [CHANGED][7144](https://github.com/stripe/stripe-android/pull/7144) PaymentSheet now features rounded corners with the radius provided in `PaymentSheet.Shapes.cornerRadiusDp`. | |||
* [FIXED][7190](https://github.com/stripe/stripe-android/pull/7190) Fixed an issue where amounts in Laotian Kip were displayed incorrectly. | |||
* [ADDED][7199](https://github.com/stripe/stripe-android/pull/7199) PaymentSheet now supports AmazonPay for PaymentIntents in private beta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can you move this to the top spot above the first CHANGED
note?
Co-authored-by: Till Hellmund <tillh@stripe.com>
8c59400
to
5e742e4
Compare
Summary
Added Amazon Pay as a new payment method to Android PaymentSheet according to this guide.
Motivation
https://jira.corp.stripe.com/browse/THREEP_API-956
Testing
Ran payment sheet example to verify the new payment method is working.
Screenshots
Changelog
[Added] Support for AmazonPay (private beta).