-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect phone and email in PaymentSheet's Google Pay #7683
Collect phone and email in PaymentSheet's Google Pay #7683
Conversation
Diffuse output:
APK
DEX
|
d786cd0
to
74959e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be helpful to document what it looks like (as a gif) too.
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think we need one more test with address collection.
8ee5abb
to
16aaa1b
Compare
16aaa1b
to
f1db248
Compare
f1db248
to
3bed4b6
Compare
Summary
This pull request updates Google Pay to take the phone and email collection configuration into account. When collection mode is set to
Always
, we now set the correctisEmailRequired
andisPhoneNumberRequired
value.The collected values are eventually accessible via the Charge’s
billing_details.email
andbilling_details.phone
fields:pi_3OHzrSLu5o3P18Zp1p1Zn1qP
pi_3OHztFLu5o3P18Zp0cZBwYwz
Motivation
Resolves #7662
Testing
Screenshots
Changelog