Keep reference to pending payment result #7704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/7590-3ds-not-working-when-activity-gets-recreated
branch
from
67cfa84 to
a3799dc
Compare
This was referenced Dec 6, 2023
samer-stripe
previously approved these changes
Dec 7, 2023
jaynewstrom-stripe
previously approved these changes
Dec 7, 2023
| ) | ||
| } | ||
|
|
||
| private fun handlePaymentSheetStateLoadFailure(error: Throwable) { | ||
| val pendingResult = pendingPaymentResult |
There was a problem hiding this comment.
Do we need to set pendingPaymentResult to null after this? Or do we just assume the view model will go away?
| if (intent == null) { | ||
| // We're recovering from process death. Wait for the pending payment result | ||
| // to be handled after re-loading. | ||
| pendingPaymentResult = launcherResult |
There was a problem hiding this comment.
Should this live in the view model? Seems like we could model this to be opaque to the view model.
There was a problem hiding this comment.
Will follow up with a better abstraction.
tillh-stripe
dismissed stale reviews from jaynewstrom-stripe and samer-stripe
via
e8b88e8
samer-stripe
approved these changes
Dec 8, 2023
tillh-stripe
deleted the
tillh/7590-3ds-not-working-when-activity-gets-recreated
branch
3 tasks
This was referenced Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes a first improvement to how we handle process death during the auth flow, with more improvements such as full state restoration still to come.
In the case of process death, the
paymentLauncherused inPaymentSheetViewModelwill return anInternalPaymentResultupon process recreation. However, the ViewModel is not yet in the correct state to handle this, as it hasn’t reloaded theStripeIntent. TherequireNotNull(stripeIntent.value)will throw.With this change, we’re delaying the handling of the
InternalPaymentResultuntil the intent has been loaded again. If the intent has been confirmed by the user, then loading the intent will fail with aPaymentIntentInTerminalStateexception. This is where we intercept: Instead of returning a fatal error to the caller, we handle the completed payment and return aPaymentResult.Completed.Due to how
PaymentLauncherworks, this is unfortunately very difficult to test 😔Motivation
Resolves #7590
Testing
Screenshots
Changelog