Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where cashapp wouldn't launch without the redirect trampoline. #7822

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

Motivation

ir-covering-concise

Copy link
Contributor

github-actions bot commented Jan 24, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │   3.6 MiB │   3.6 MiB │ -191 B │   7.8 MiB │   7.8 MiB │ +220 B 
     arsc │   2.4 MiB │   2.4 MiB │    0 B │   2.4 MiB │   2.4 MiB │    0 B 
 manifest │   5.1 KiB │   5.1 KiB │    0 B │  25.4 KiB │  25.4 KiB │    0 B 
      res │ 926.8 KiB │ 926.8 KiB │    0 B │   1.4 MiB │   1.4 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │    0 B 
    asset │     3 MiB │     3 MiB │   +3 B │     3 MiB │     3 MiB │   +3 B 
    other │ 205.4 KiB │ 205.4 KiB │   +1 B │ 462.3 KiB │ 462.3 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  12.6 MiB │  12.6 MiB │ -187 B │  21.1 MiB │  21.1 MiB │ +223 B 

 DEX     │ old   │ new   │ diff           
─────────┼───────┼───────┼────────────────
   files │     1 │     1 │  0             
 strings │ 39173 │ 39174 │ +1 (+11 -10)   
   types │ 13073 │ 13073 │  0 (+9 -9)     
 classes │ 11044 │ 11044 │  0 (+1 -1)     
 methods │ 54520 │ 54520 │  0 (+226 -226) 
  fields │ 36194 │ 36193 │ -1 (+117 -118) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  327 │  327 │  0   
 entries │ 6948 │ 6948 │  0
APK
    compressed     │    uncompressed    │                                
──────────┬────────┼───────────┬────────┤                                
 size     │ diff   │ size      │ diff   │ path                           
──────────┼────────┼───────────┼────────┼────────────────────────────────
  3.6 MiB │ -191 B │   7.8 MiB │ +220 B │ ∆ classes.dex                  
  5.4 KiB │   +5 B │   5.3 KiB │   +5 B │ ∆ assets/dexopt/baseline.prof  
 66.1 KiB │   +5 B │ 148.2 KiB │    0 B │ ∆ META-INF/CERT.SF             
 50.4 KiB │   -3 B │ 148.1 KiB │    0 B │ ∆ META-INF/MANIFEST.MF         
    844 B │   -2 B │     712 B │   -2 B │ ∆ assets/dexopt/baseline.profm 
  1.2 KiB │   -1 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA            
──────────┼────────┼───────────┼────────┼────────────────────────────────
  3.7 MiB │ -187 B │   8.1 MiB │ +223 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   39173 │ 39174 │ +1 (+11 -10) 
  + Lwd/w0;
  + [Lrd/h;
  + [Lwd/e0;
  + [Lwd/g0;
  + [Lwd/k0;
  + [Lwd/n0;
  + [Lwd/s;
  + [Lwd/u;
  + [Lwd/w0;
  + createChooser(intent, intentChooserTitle)
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:9cd1120,r8-mode:full,version:8.2.33}
  
  - Lrd/k;
  - [Lrd/j;
  - [Lwd/d0;
  - [Lwd/f0;
  - [Lwd/i0;
  - [Lwd/m0;
  - [Lwd/r;
  - [Lwd/t;
  - [Lwd/v0;
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:f5f5b8f,r8-mode:full,version:8.2.33}
  

TYPES:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   13073 │ 13073 │ 0 (+9 -9) 
  + Lwd/w0;
  + [Lrd/h;
  + [Lwd/e0;
  + [Lwd/g0;
  + [Lwd/k0;
  + [Lwd/n0;
  + [Lwd/s;
  + [Lwd/u;
  + [Lwd/w0;
  
  - Lrd/k;
  - [Lrd/j;
  - [Lwd/d0;
  - [Lwd/f0;
  - [Lwd/i0;
  - [Lwd/m0;
  - [Lwd/r;
  - [Lwd/t;
  - [Lwd/v0;
  

METHODS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   54520 │ 54520 │ 0 (+226 -226) 
  + bd.s <init>(q, f, int, String, String, j1)
  + c0.f U1(String, Object) → j0
  + com.stripe.android.paymentsheet.example.playground.PaymentSheetPlaygroundActivity p(PaymentSheetPlaygroundActivity, q0, k, int)
  + com.stripe.android.paymentsheet.example.playground.PaymentSheetPlaygroundActivity q(PaymentSheetPlaygroundActivity, q0, k, int)
  + fb.a <init>(j0, j1, String, int, List, c)
  + hd.b c(String) → q0
  + jd.d B(i, k, int)
  + kf.a J(k0, q0, k, int)
  + kf.a K(q0, k, int)
  + nd.z <init>(PaymentSheetPlaygroundActivity, q0, j1, x2, h2, p)
  + rd.f <init>(List, List)
  + rd.f h0(Object, Object, Object, Object) → Object
  + rd.g <init>()
  + rd.g equals(Object) → boolean
  + rd.g hashCode() → int
  + rd.g toString() → String
  + rd.h <clinit>()
  + rd.h valueOf(String) → h
  + rd.h values() → h[]
  + rd.i <init>(int, int, Class, g, h)
  + rd.i equals(Object) → boolean
  + rd.i hashCode() → int
  + rd.i toString() → String
  + rd.j <init>(Application)
  + rd.j a(String) → String
  + sc.y I0(n0) → m0
  + sc.y c0(d2, z, l0)
  + sg.m <init>(m4, List, k)
  + td.l <init>(PaymentSheetPlaygroundActivity, q0, int, int)
  + td.x <init>(q0, y, e)
  + td.z <init>(p0, long, List, f2, String)
  + wd.a0 f(Object, b)
  + wd.a0 l(boolean, b)
  + wd.a g() → m0
  + wd.a h(Object, d2, z, l0)
  + wd.a j(Object, q0)
  + wd.b0 <clinit>()
  + wd.b0 h(Object, d2, z, l0)
  + wd.b0 k(boolean, d2, z, l0)
  + wd.b h(Object, d2, z, l0)
  + wd.b k(boolean, d2, z, l0)
  + wd.c0 <init>(String, w0, w0[])
  + wd.c0 a(String) → w0
  + wd.c0 c(String) → Object
  + wd.c0 d() → boolean
  + wd.c0 e(Object) → String
  + wd.c0 getKey() → String
  + wd.d0 h(Object, d2, z, l0)
  + wd.d0 k(boolean, d2, z, l0)
  + wd.e0 <init>(String, int, String)
  + wd.e0 getValue() → String
  + wd.e0 valueOf(String) → e0
  + wd.e0 values() → e0[]
  + wd.e g() → m0
  + wd.e h(Object, d2, z, l0)
  + wd.e j(Object, q0)
  + wd.e k(boolean, d2, z, l0)
  + wd.f0 <init>()
  + wd.f0 a() → String
  + wd.f0 b() → Object
  + wd.f0 c(String) → Object
  + wd.f0 d() → boolean
  + wd.f0 e(Object) → String
  + wd.f0 f(Object, b)
  + wd.f0 g() → m0
  + wd.f0 getKey() → String
  + wd.f0 h(Object, d2, z, l0)
  + wd.f0 i() → List
  + wd.f0 j(Object, q0)
  + wd.g0 <init>(String, int, String)
  + wd.g0 getValue() → String
  + wd.g0 valueOf(String) → g0
  + wd.g0 values() → g0[]
  + wd.h0 <init>()
  + wd.h0 a() → String
  + wd.h0 b() → Object
  + wd.h0 c(String) → Object
  + wd.h0 d() → boolean
  + wd.h0 e(Object) → String
  + wd.h0 g() → m0
  + wd.h0 getKey() → String
  + wd.h0 h(Object, d2, z, l0)
  + wd.h0 i() → List
  + wd.h0 j(Object, q0)
  + wd.i0 <clinit>()
  + wd.i0 f(Object, b)
  + wd.i0 l(boolean, b)
  + wd.j0 <init>(Object, String)
  + wd.j0 equals(Object) → boolean
  + wd.j0 hashCode() → int
  + wd.j0 toString() → String
  + wd.j g() → m0
  + wd.j h(Object, d2, z, l0)
  + wd.j j(Object, q0)
  + wd.k0 a() → String
  + wd.k0 i() → List
  + wd.k <init>(int, Object)
  + wd.k M(Object) → Object
  + wd.k a(int) → String
  + wd.k b(p)
  + wd.k c(Throwable)
  + wd.k d(a)
  + wd.l0 <init>(d2)
  + wd.l0 a(c)
  + wd.l0 equals(Object) → boolean
  + wd.l0 hashCode() → int
  + wd.l0 toString() → String
  + wd.l l() → Object
  + wd.m0 c(String) → Object
  + wd.m0 d() → boolean
  + wd.m0 e(Object) → String
  + wd.m0 getKey() → String
  + wd.m <clinit>()
  + wd.m a() → String
  + wd.m b() → Obj
...✂

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review January 25, 2024 00:29
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners January 25, 2024 00:29
@jaynewstrom-stripe jaynewstrom-stripe merged commit 5d71352 into master Jan 25, 2024
11 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/ir-covering-concise branch January 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants