Refactor validation errors from Payment- & CustomerSheetLoader #7872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/fix-badparcelable-with-loading-exception
branch
from
8d753e9 to
2ce55b3
Compare
tillh-stripe
force-pushed
the
tillh/fix-badparcelable-with-loading-exception
branch
from
2ce55b3 to
b4ccb24
Compare
tillh-stripe
requested review from
carlosmuvi-stripe,
jaynewstrom-stripe and
samer-stripe
and removed request for
carlosmuvi-stripe
jaynewstrom-stripe
previously approved these changes
Feb 5, 2024
tillh-stripe
force-pushed
the
tillh/fix-badparcelable-with-loading-exception
branch
from
8eefeaf to
b3a2e68
Compare
jaynewstrom-stripe
approved these changes
Feb 5, 2024
tillh-stripe
deleted the
tillh/fix-badparcelable-with-loading-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue where an unserializable
ThrowableinPaymentSheetResult.Failedcaused a crash. The cause turned out to be theAddressin thePaymentMethodobject.Now, we no longer include the entire
PaymentMethodin the exception, but rather keep this information in thePaymentSheetViewModel.Motivation
Testing
Screenshots
Changelog