[FC] Removes mavericks from all viewmodels and tests #8155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmuvi-stripe
changed the title
|
Diffuse output: |
Base automatically changed from
carlosmuvi/remove-mavericks-part-2
to
carlosmuvi/i/remove-mavericks
March 26, 2024 16:31
…nto carlosmuvi/remove-mavericks-part-3 # Conflicts: # financial-connections/src/test/java/com/stripe/android/financialconnections/features/accountpicker/AccountPickerViewModelTest.kt # financial-connections/src/test/java/com/stripe/android/financialconnections/features/partnerauth/PartnerAuthViewModelTest.kt
carlosmuvi-stripe
requested review from
jaynewstrom-stripe and
tillh-stripe
and removed request for
a team and
jaynewstrom-stripe
| @@ -994,15 +994,6 @@ | |||
| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22 -> 1.9.10 (*) | |||
| | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:{require 1.6.4; reject _} -> 1.7.3 (*) | |||
| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22 -> 1.9.10 (*) | |||
| | +--- com.airbnb.android:mavericks-compose:3.0.9 | |||
There was a problem hiding this comment.
Should we rename this file or move the extensions?
| @@ -42,7 +43,7 @@ import org.mockito.kotlin.whenever | |||
| class LinkAccountPickerViewModelTest { | |||
|
|
|||
| @get:Rule | |||
| val mavericksTestRule = MavericksTestRule() | |||
| val testRule = CoroutineTestRule(UnconfinedTestDispatcher()) | |||
There was a problem hiding this comment.
Nit!
Suggested change
| val testRule = CoroutineTestRule(UnconfinedTestDispatcher()) | |
| val testRule = CoroutineTestRule() |
| @@ -109,7 +109,7 @@ class LinkStepUpVerificationViewModelTest { | |||
|
|
|||
| val viewModel = buildViewModel() | |||
|
|
|||
| assertThat(viewModel.awaitState().payload).isInstanceOf(Loading::class.java) | |||
| assertThat(viewModel.stateFlow.value.payload).isInstanceOf(Loading::class.java) | |||
There was a problem hiding this comment.
Should we test this with Turbine to be more explicit about when we expect a new state and when we don’t?
There was a problem hiding this comment.
(Added an example asserting no events are emitted after consumer lookup results in no user found)
| @get:Rule | ||
| val mavericksTestRule = MavericksTestRule(testDispatcher = testDispatcher) | ||
| val testRule = CoroutineTestRule(UnconfinedTestDispatcher()) |
There was a problem hiding this comment.
Nit!
Suggested change
| val testRule = CoroutineTestRule(UnconfinedTestDispatcher()) | |
| val testRule = CoroutineTestRule() |
carlosmuvi-stripe
merged commit 1f0f397
into
carlosmuvi/i/remove-mavericks
12 of 13 checks passed
carlosmuvi-stripe
added a commit
that referenced
this pull request
Mar 27, 2024
* [FC] Moves Activities and some Panes out of Mavericks (#8125) * Removes mackericks references on Consent screen. * Updates files. * Uses viewmodel factory builder. * Updates functions. * Updates execute. * Updates compose util. * Adds missing side effects. * Simplifies code. * Renames viewmodel. * Updates async. * Removes mavericks from institution picker. * Reverts rename. * Updates baseline. * Adds setState and persists state. * Renames result error to fail. * Migrates Initial activity out of mavericks. * Removes persist state. * Updates tests. * Regenerates API. * filterNotNull. * Nits. * Updates async. * use suspend block. * Update financial-connections/src/main/java/com/stripe/android/financialconnections/core/FinancialConnectionsViewModel.kt Co-authored-by: Till Hellmund <tillh@stripe.com> * Tries onAsync. * Moves activity to stripe ui core. * PR feedback. * Regenerates deps. --------- Co-authored-by: Till Hellmund <tillh@stripe.com> * [FC] Removes mavericks from repositories and more panes. (#8154) * Migrates more screens out of mavs. * Migrates partner auth. * Removes active auth session field. * Updates tests. * Updates attach payment viewmodel. * PR feedback. * Api dump. * [FC] Removes mavericks from all viewmodels and tests (#8155) * Migrates more screens out of mavs. * Migrates partner auth. * Removes active auth session field. * Updates tests. * Updates attach payment viewmodel. * PR feedback. * Api dump. * Migrates missing viewmodels. * Updates dependencies. * PR feedback. * Merge master. * [FC] Removes mavericks dependency (#8160) * Migrates more screens out of mavs. * Migrates partner auth. * Removes active auth session field. * Updates tests. * Updates attach payment viewmodel. * PR feedback. * Api dump. * Migrates missing viewmodels. * Updates dependencies. * Removes mavericks dependency. * Merge with integration. * Uses collect. * Updates dependencies * Updates Changelog. * Update CHANGELOG.md Co-authored-by: Till Hellmund <tillh@stripe.com> --------- Co-authored-by: Till Hellmund <tillh@stripe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Screenshots
Changelog