Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CustomerSheet ACHv2 flag. #8176

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Mar 29, 2024

Summary

Removes the CustomerSheet ACHv2 flag.

Motivation

No longer needed since we are now showing GAing ACHv2 with CustomerSheet.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Mar 29, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │   3.9 MiB │   3.9 MiB │ -198 B │   8.5 MiB │   8.5 MiB │ -1.2 KiB 
     arsc │   2.2 MiB │   2.2 MiB │    0 B │   2.2 MiB │   2.2 MiB │      0 B 
 manifest │     5 KiB │     5 KiB │    0 B │  24.9 KiB │  24.9 KiB │      0 B 
      res │ 911.1 KiB │ 911.1 KiB │    0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │   -6 B │     3 MiB │     3 MiB │     -6 B 
    other │ 204.3 KiB │ 204.2 KiB │   -5 B │ 445.3 KiB │ 445.3 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  12.8 MiB │  12.8 MiB │ -209 B │  21.6 MiB │  21.6 MiB │ -1.2 KiB 

 DEX     │ old   │ new   │ diff         
─────────┼───────┼───────┼──────────────
   files │     1 │     1 │  0           
 strings │ 42430 │ 42427 │ -3 (+3 -6)   
   types │ 14440 │ 14438 │ -2 (+1 -3)   
 classes │ 12174 │ 12172 │ -2 (+0 -2)   
 methods │ 60347 │ 60343 │ -4 (+60 -64) 
  fields │ 39932 │ 39930 │ -2 (+58 -60) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6029 │ 6029 │  0
APK
    compressed     │     uncompressed     │                                           
──────────┬────────┼───────────┬──────────┤                                           
 size     │ diff   │ size      │ diff     │ path                                      
──────────┼────────┼───────────┼──────────┼───────────────────────────────────────────
  3.9 MiB │ -198 B │   8.5 MiB │ -1.2 KiB │ ∆ classes.dex                             
  7.4 KiB │   -5 B │   7.2 KiB │     -5 B │ ∆ assets/dexopt/baseline.prof             
 62.1 KiB │   -3 B │   140 KiB │      0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │   -2 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
    272 B │   +1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
    887 B │   -1 B │     755 B │     -1 B │ ∆ assets/dexopt/baseline.profm            
 53.2 KiB │   -1 B │ 139.9 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼────────┼───────────┼──────────┼───────────────────────────────────────────
    4 MiB │ -209 B │   8.8 MiB │ -1.2 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   42430 │ 42427 │ -3 (+3 -6) 
  
  + LLZZZZZZLLLI
  + [LV4/g;
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:5eadebf,r8-mode:full,version:8.3.37}
  
  - LLZZZZZZZLLLI
  - LS6/O;
  - LV4/k;
  - US Bank Accounts
  - [LV4/h;
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:a5a580e,r8-mode:full,version:8.3.37}
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   14440 │ 14438 │ -2 (+1 -3) 
  
  + [LV4/g;
  
  - LS6/O;
  - LV4/k;
  - [LV4/h;
  

METHODS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   60347 │ 60343 │ -4 (+60 -64) 
  
  + S4.x <init>(Application, S, e, f)
  + S6.A <init>(h, e)
  + S6.C <init>(J, e)
  + S6.D <init>(E, e)
  + S6.E <init>(g, J, int)
  + S6.E a(Object, e) → Object
  + S6.F <init>(s0, J, int)
  + S6.F b(g, e) → Object
  + S6.G <init>(E, e)
  + S6.G i(Object) → Object
  + S6.H <init>(J, e)
  + S6.H G(Object, Object) → Object
  + S6.H f(Object, e) → e
  + S6.I <init>(J, e)
  + S6.J <init>(Application)
  + S6.J c(boolean) → F0
  + S6.J d(String, e) → Object
  + S6.J e(J, e) → Object
  + S6.J f(J)
  + S6.K <init>(Y0, String, String, String, String)
  + S6.K a(K, Y0, String) → K
  + S6.K equals(Object) → boolean
  + S6.K hashCode() → int
  + S6.K toString() → String
  + S6.L <init>(String)
  + S6.M <clinit>()
  + S6.c <init>(int, c)
  + S6.c K(Object) → Object
  + S6.c a(String)
  + S6.c b(boolean)
  + S6.d <init>(CustomerSheetPlaygroundActivity, l, c, int, int)
  + S6.d G(Object, Object) → Object
  + S6.d a(k, int)
  + S6.l a(l, boolean, boolean, boolean, boolean, boolean, boolean, I0, String, String, int) → l
  + S6.r <init>(String)
  + S6.r equals(Object) → boolean
  + S6.r hashCode() → int
  + S6.r toString() → String
  + S6.x <init>(J, e)
  + S6.x G(Object, Object) → Object
  + S6.x f(Object, e) → e
  + S6.x i(Object) → Object
  + S6.y <clinit>()
  + S6.y create(Class) → w0
  + S6.y create(Class, c) → w0
  + S6.z <init>(String, e)
  + S6.z G(Object, Object) → Object
  + S6.z f(Object, e) → e
  + S6.z i(Object) → Object
  + V4.g <clinit>()
  + V4.g <init>(int, String, String, String)
  + V4.g valueOf(String) → g
  + V4.g values() → g[]
  + V4.i <init>(j, e)
  + V4.i i(Object) → Object
  + V4.j <init>(e)
  + V4.j a(e) → Object
  + com.stripe.android.paymentsheet.example.samples.ui.customersheet.playground.CustomerSheetPlaygroundActivity l(CustomerSheetPlaygroundActivity, K, a, k, int)
  + com.stripe.android.paymentsheet.example.samples.ui.customersheet.playground.CustomerSheetPlaygroundActivity m(CustomerSheetPlaygroundActivity, l, c, k, int)
  + com.stripe.android.paymentsheet.example.samples.ui.customersheet.playground.CustomerSheetPlaygroundActivity o(CustomerSheetPlaygroundActivity) → J
  
  - S4.x <init>(Application, S, e, g)
  - S6.A <init>(String, e)
  - S6.A G(Object, Object) → Object
  - S6.A f(Object, e) → e
  - S6.C <init>(h, e)
  - S6.D <init>(K, e)
  - S6.E <init>(F, e)
  - S6.E i(Object) → Object
  - S6.F <init>(g, K, int)
  - S6.F a(Object, e) → Object
  - S6.G <init>(s0, K, int)
  - S6.G b(g, e) → Object
  - S6.H <init>(F, e)
  - S6.I <init>(K, e)
  - S6.J <init>(K, e)
  - S6.J G(Object, Object) → Object
  - S6.J f(Object, e) → e
  - S6.J i(Object) → Object
  - S6.K <init>(Application)
  - S6.K c(boolean) → F0
  - S6.K d(String, e) → Object
  - S6.K e(K, e) → Object
  - S6.K f(J)
  - S6.L <init>(Y0, String, String, String, String)
  - S6.L a(L, Y0, String) → L
  - S6.M <init>(String)
  - S6.M equals(Object) → boolean
  - S6.M hashCode() → int
  - S6.M toString() → String
  - S6.N <clinit>()
  - S6.c <init>(CustomerSheetPlaygroundActivity, l, c, int, int)
  - S6.c G(Object, Object) → Object
  - S6.c a(k, int)
  - S6.d <init>(int, c)
  - S6.d K(Object) → Object
  - S6.d a(String)
  - S6.d b(boolean)
  - S6.l a(l, boolean, boolean, boolean, boolean, boolean, boolean, boolean, I0, String, String, int) → l
  - S6.r <clinit>()
  - S6.w <init>(String)
  - S6.w equals(Object) → boolean
  - S6.w hashCode() → int
  - S6.w toString() → String
  - S6.y <init>(K, e)
  - S6.y G(Object, Object) → Object
  - S6.y f(Object, e) → e
  - S6.y i(Object) → Object
  - S6.z <clinit>()
  - S6.z create(Class) → w0
  - S6.z create(Class, c) → w0
  - V4.f <clinit>()
  - V4.h <init>(int, String, String, String)
  - V4.h valueOf(String) → h
  - V4.h values() → h[]
  - V
...✂

…in `CustomerSheetActivity` into a single test.
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a changelog note?

@samer-stripe samer-stripe merged commit 8d1d87d into master Mar 29, 2024
15 checks passed
@samer-stripe samer-stripe deleted the samer/remove-ach-v2-flag branch March 29, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants