-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CustomerSheet ACHv2
flag.
#8176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samer-stripe
requested review from
carlosmuvi-stripe,
jaynewstrom-stripe and
amk-stripe
and removed request for
carlosmuvi-stripe
March 29, 2024 19:25
samer-stripe
commented
Mar 29, 2024
paymentsheet/src/main/java/com/stripe/android/customersheet/CustomerSheetLoader.kt
Show resolved
Hide resolved
paymentsheet/src/test/java/com/stripe/android/customersheet/CustomerSheetActivityTest.kt
Outdated
Show resolved
Hide resolved
Diffuse output:
APK
DEX
|
…in `CustomerSheetActivity` into a single test.
jaynewstrom-stripe
previously approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding a changelog note?
jaynewstrom-stripe
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the CustomerSheet
ACHv2
flag.Motivation
No longer needed since we are now showing GAing ACHv2 with
CustomerSheet
.Testing