Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keys to remember functions in FlowControllerCompose.kt and PaymentSheetCompose.kt #8480

Merged
merged 2 commits into from
May 20, 2024

Conversation

amk-stripe
Copy link
Collaborator

@amk-stripe amk-stripe commented May 17, 2024

Summary

Add keys to remember functions in FlowControllerCompose.kt and PaymentSheetCompose.kt

Motivation

Recreate PaymentSheet/FlowController if its parameters change

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

  • [CHANGED]8340 Recreate PaymentSheet/FlowController in rememberPaymentSheet functions when an input callback changes.

@@ -108,7 +108,7 @@ private fun internalRememberPaymentSheetFlowController(
"PaymentSheet.FlowController must be created in the context of an Activity"
}

return remember {
return remember(paymentOptionCallback, paymentResultCallback) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From #8466, @jaynewstrom-stripe you suggested including createIntentCallback, externalPaymentMethodConfirmHandler in here as well. Those are updated in their own LaunchedEffects which already should re-run when they change. I don't think we actually need to recreate PaymentSheet + FlowController as well. Lmk if I'm missing something though!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

Copy link
Contributor

github-actions bot commented May 17, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.5 MiB │   1.5 MiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
    other │    87 KiB │    87 KiB │ -4 B │ 161.5 KiB │ 161.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.2 MiB │  12.2 MiB │ -4 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21686 │ 21686 │ 0 (+0 -0) 
   types │  6869 │  6869 │ 0 (+0 -0) 
 classes │  5634 │  5634 │ 0 (+0 -0) 
 methods │ 31447 │ 31447 │ 0 (+0 -0) 
  fields │ 18315 │ 18315 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 25.9 KiB │ -3 B │  63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
 29.1 KiB │ -1 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF     
──────────┼──────┼───────────┼──────┼────────────────────────
 54.9 KiB │ -4 B │ 127.9 KiB │  0 B │ (total)

Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth a changelog callout.

@amk-stripe amk-stripe enabled auto-merge (squash) May 20, 2024 19:30
@amk-stripe amk-stripe merged commit c554ab1 into master May 20, 2024
12 checks passed
@amk-stripe amk-stripe deleted the add-keys-to-remember-ps branch May 20, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants