Correctly parse JSON when creating or deleting customer card source #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `POST /v1/customers/:customer_id/sources` and `DELETE /v1/customers/:customer_id/sources/:source_id` return a different shape depending on whether the object referenced by `:source_id` is a `Source` or a `Card`. The current implementation was not handling the `Card` case. The impact of this is that the listener passed to either `CustomerSession#addCustomerSource` or `CustomerSession#deleteCustomerSource` was not being called when the source was a `Card`. The short-term fix is to create a `Source` object and only populate its `id` field. This is not ideal because we are creating a `Source` with a card id, but it resolves the issue of the listener not being called. The long-term fix is to pass a `StripePaymentSource` to the listener. ANDROID-344
jemerick-stripe
approved these changes
Apr 9, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Both
POST /v1/customers/:customer_id/sourcesandDELETE /v1/customers/:customer_id/sources/:source_idreturna different shape depending on whether the object referenced by
:source_idis aSourceor aCard. The current implementationwas not handling the
Cardcase. The impact of this is that thelistener passed to either
CustomerSession#addCustomerSourceorCustomerSession#deleteCustomerSourcewas not being called whenthe source was a
Card.The short-term fix is to create a
Sourceobject and only populateits
idfield. This is not ideal because we are creating aSourcewith a card id, but it resolves the issue of the listener not being
called.
The long-term fix is to pass a
StripePaymentSourceto thelistener.
Motivation
ANDROID-344
Testing
Unit tests