Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Pay tests #9157

Closed
wants to merge 3 commits into from
Closed

Add Google Pay tests #9157

wants to merge 3 commits into from

Conversation

samer-stripe
Copy link
Collaborator

Summary

Add Google Pay tests

Motivation

Add Google Pay tests

Testing

  • Added tests
  • Modified tests
  • Manually verified

@samer-stripe samer-stripe force-pushed the samer/google-pay-tests branch from 3bcd758 to be1137a Compare August 29, 2024 21:53
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.9 MiB │   3.9 MiB │    -62 B │   8.5 MiB │   8.5 MiB │   +244 B 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │   2.3 MiB │   2.3 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │  25.6 KiB │  25.6 KiB │      0 B 
      res │ 932.5 KiB │ 932.5 KiB │      0 B │   1.5 MiB │   1.5 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │   2.9 MiB │   2.9 MiB │ +1.5 KiB │   2.9 MiB │   2.9 MiB │ +1.5 KiB 
    other │ 195.8 KiB │ 195.8 KiB │     -5 B │ 430.3 KiB │ 430.3 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.8 MiB │  12.8 MiB │ +1.4 KiB │  21.7 MiB │  21.7 MiB │ +1.7 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 42433 │ 42434 │ +1 (+2 -1) 
   types │ 14029 │ 14029 │  0 (+0 -0) 
 classes │ 11689 │ 11689 │  0 (+0 -0) 
 methods │ 60048 │ 60049 │ +1 (+6 -5) 
  fields │ 39864 │ 39865 │ +1 (+2 -1) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6252 │ 6252 │  0
APK
     compressed      │     uncompressed     │                               
──────────┬──────────┼───────────┬──────────┤                               
 size     │ diff     │ size      │ diff     │ path                          
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  7.8 KiB │ +1.5 KiB │   7.7 KiB │ +1.5 KiB │ ∆ assets/dexopt/baseline.prof 
  3.9 MiB │    -62 B │   8.5 MiB │   +244 B │ ∆ classes.dex                 
 53.3 KiB │     -6 B │ 118.1 KiB │      0 B │ ∆ META-INF/CERT.SF            
 50.1 KiB │     +2 B │ 118.1 KiB │      0 B │ ∆ META-INF/MANIFEST.MF        
  1.2 KiB │     -1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA           
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
    4 MiB │ +1.4 KiB │   8.8 MiB │ +1.7 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   42433 │ 42434 │ +1 (+2 -1) 
  
  + VLLLZLZI
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:cadaf8b,r8-mode:full,version:8.5.35}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:e46221c,r8-mode:full,version:8.5.35}
  

METHODS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   60048 │ 60049 │ +1 (+6 -5) 
  
  + c1.t d(j, a)
  + c1.t e(j, String)
  + c1.t f(j, int)
  + c1.t g(j, String)
  + c1.t h(j, e)
  + o6.F <init>(f, String, String, boolean, E, boolean, int)
  
  - c1.t d(j, String)
  - c1.t e(j, int)
  - c1.t f(j, String)
  - c1.t g(j, e)
  - o6.F <init>(f, String, String, boolean, E)
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   39864 │ 39865 │ +1 (+2 -1) 
  
  + Z6.F1 S: F1
  + Z6.F1 T: F1[]
  
  - Z6.F1 S: F1[]

@samer-stripe samer-stripe force-pushed the samer/google-pay-tests branch 2 times, most recently from db15756 to d934693 Compare August 29, 2024 22:32
@@ -417,6 +419,43 @@ internal class PlaygroundTestDriver(
return result
}

fun confirmWithGooglePay(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will eventually want an assumeTrue or similar to make these not run unless we want them to (only for the new job).

@samer-stripe samer-stripe force-pushed the samer/google-pay-tests branch 6 times, most recently from 5c85409 to b2c5821 Compare September 2, 2024 21:11
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

@samer-stripe samer-stripe added the accept-risky-change accept-risky-change label Sep 2, 2024
@samer-stripe samer-stripe force-pushed the samer/google-pay-tests branch 10 times, most recently from 590dd8e to 45e78e3 Compare September 5, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accept-risky-change accept-risky-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants