Update CVC Recollection API for Deferred Intent flow #9158

tjclawson-stripe · 2024-08-29T22:04:25Z

Summary

Update CVC Recollection API

Motivation

API Review
Integration Guide

Testing

Added tests
Modified tests
Manually verified

Changelog

github-actions · 2024-08-29T22:10:28Z

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   1.9 MiB │   1.9 MiB │  0 B │     4 MiB │     4 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.8 KiB │   6.8 KiB │  0 B │   6.6 KiB │   6.6 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │ +5 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.5 MiB │   9.5 MiB │ +5 B │  21.4 MiB │  21.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20269 │ 20269 │ 0 (+0 -0) 
   types │  6106 │  6106 │ 0 (+0 -0) 
 classes │  4913 │  4913 │ 0 (+0 -0) 
 methods │ 29561 │ 29561 │ 0 (+0 -0) 
  fields │ 17371 │ 17371 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3608 │ 3608 │  0

APK

   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 28.3 KiB │ +7 B │  62.6 KiB │  0 B │ ∆ META-INF/CERT.SF     
  1.2 KiB │ -1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
 25.1 KiB │ -1 B │  62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼───────────┼──────┼────────────────────────
 54.6 KiB │ +5 B │ 126.3 KiB │  0 B │ (total)

jaynewstrom-stripe

Can you add a note to the changelog?

paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheet.kt

jaynewstrom-stripe · 2024-09-04T19:42:02Z

CHANGELOG.md

@@ -2,6 +2,8 @@

 ## XX.XX.XX - 20XX-XX-XX

+*[ADDED][9158](https://github.com/stripe/stripe-android/pull/9158) Add `requireCvcRecollection` param to `IntentConfiguration`


We should mention this is still in private beta, it's a breaking API change, and how to migrate.

Hmm, we have the migration docs ready but they're not deployed. Should I remove the changelog addition and add once we're ready to GA?

We need to mention the breaking change (removing the callback). Ideally we point to the migration guide as well.

Added verbiage about breaking change and private beta. Will update to point to migration guide if we have approval by the next release

paymentsheet/api/paymentsheet.api

...tsheet/src/main/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowController.kt

...et/src/test/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowControllerTest.kt

emerge-tools · 2024-09-05T17:26:40Z

3 builds increased size

Name	Version	Download	Change	Install	Change	Approval
Stripe Identity Example com.stripe.android.identity.example.theme1	20.48.6-theme1 (20)	3.8 MB	⬆️ 2.7 kB (0.07%)	8.9 MB	⬆️ 9.0 kB (0.1%)	N/A
⚠️ Financial Connections Example com.stripe.android.financialconnections.example	20.48.6 (204806)	4.2 MB	⬆️ 650.7 kB (18.39%)	9.3 MB	⬆️ 1.5 MB (19.34%)	N/A
PaymentSheet Example com.stripe.android.paymentsheet.example	20.48.6 (11)	8.5 MB	⬆️ 11.2 kB (0.13%)	16.0 MB	⬆️ 28.7 kB (0.18%)	N/A

Stripe Identity Example 20.48.6-theme1 (20)
com.stripe.android.identity.example.theme1

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 9.0 kB (0.1%)
Total download size change: ⬆️ 2.7 kB (0.07%)

Largest size changes

Item	Install Size Change	Download Size Change
🗑 androidx.compose.ui.text.android.selection.WordIterator$Companion	⬇️ -38.2 kB	⬇️ -18.3 kB
📝 androidx.fragment.app.FragmentAnim$AnimationOrAnimator	⬆️ 33.1 kB	⬆️ 15.9 kB
🗑 androidx.emoji2.viewsintegration.EmojiEditTextHelper$HelperIntern...	⬇️ -33.1 kB	⬇️ -15.9 kB
androidx.transition.ViewUtilsApi21	⬆️ 32.9 kB	⬆️ 15.8 kB
📝 androidx.activity.compose.BackHandlerKt	⬆️ 28.6 kB	⬆️ 13.7 kB

View Treemap

Financial Connections Example 20.48.6 (204806)
com.stripe.android.financialconnections.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 1.5 MB (19.34%)
Total download size change: ⬆️ 650.7 kB (18.39%)

Largest size changes

Item	Install Size Change	Download Size Change
kotlin.sequences.SequencesKt__SequencesJVMKt	⬆️ 68.8 kB	⬆️ 32.5 kB
📝 androidx.fragment.app.SpecialEffectsController$Operation$State$Co...	⬆️ 65.3 kB	⬆️ 30.8 kB
androidx.work.impl.model.RawWorkInfoDao_Impl	⬆️ 53.9 kB	⬆️ 25.3 kB
📝 com.google.android.gms.dynamite.zzb	⬆️ 50.7 kB	⬆️ 23.9 kB
kotlin.collections.MapsKt__MapsKt	⬇️ -46.7 kB	⬇️ -22.3 kB

View Treemap

PaymentSheet Example 20.48.6 (11)
com.stripe.android.paymentsheet.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 28.7 kB (0.18%)
Total download size change: ⬆️ 11.2 kB (0.13%)

Largest size changes

Item	Install Size Change	Download Size Change
kotlin.collections.SetsKt	⬆️ 36.6 kB	⬆️ 16.7 kB
kotlin.collections.MapsKt__MapsKt	⬇️ -35.5 kB	⬇️ -16.2 kB
🗑 androidx.emoji2.text.MetadataListReader	⬇️ -28.7 kB	⬇️ -13.1 kB
📝 androidx.compose.foundation.layout.IntrinsicKt	⬆️ 25.8 kB	⬆️ 11.8 kB
📝 com.google.android.material.textfield.IconHelper	⬆️ 23.0 kB	⬆️ 10.5 kB

View Treemap

🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

jaynewstrom-stripe · 2024-09-05T17:48:56Z

CHANGELOG.md

@@ -2,7 +2,7 @@

 ## XX.XX.XX - 20XX-XX-XX

-*[ADDED][9158](https://github.com/stripe/stripe-android/pull/9158) Add `requireCvcRecollection` param to `IntentConfiguration`
+*[ADDED][9158](https://github.com/stripe/stripe-android/pull/9158) Add `requireCvcRecollection` param to `IntentConfiguration`. Currently in private beta. This is a breaking change for merchants using `PaymentSheet.Builder.cvcRecollectionEnabledCallback` and `PaymentSheet.FlowController.Builder.cvcRecollectionEnabledCallback`


I think we could reword this to be a little more clear.

A few things:

Let's update the tag from [ADDED] -> [BREAKING]

Let's start with something like "Updates to CVC recollection APIs, currently in private beta", then list the changes

Let's also mention (probably at the end) this is still in private beta, and requires the experimental API annotation.

Updated 👍

jaynewstrom-stripe · 2024-09-09T17:14:02Z

paymentsheet/src/test/java/com/stripe/android/paymentsheet/analytics/PaymentSheetEventTest.kt

@@ -328,7 +328,8 @@ class PaymentSheetEventTest {
                "duration" to 5f,
                "selected_lpm" to "none",
                "intent_type" to "payment_intent",
-                "ordered_lpms" to "card,klarna"
+                "ordered_lpms" to "card,klarna",
+                "require_cvc_recollection" to false


Please separate analytics into another PR.

Reverted, will add in follow up PR

Update CVC Recollection API for Deferred Intent flow

28ad0ef

tjclawson-stripe requested review from a team as code owners August 29, 2024 22:04

tjclawson-stripe requested a review from jaynewstrom-stripe August 29, 2024 22:04

jaynewstrom-stripe reviewed Aug 30, 2024

View reviewed changes

paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheet.kt Outdated Show resolved Hide resolved

tjclawson-stripe added 5 commits August 30, 2024 12:14

Lint

3fb8c9f

Merge branch 'master' into cvc-api-update

a8f1723

Update CHANGELOG.md

701bd36

API dump

0a5eb38

Remove ExperimentalCvcRecollectionApi

72cae89

tjclawson-stripe added the DO-NOT-MERGE label Aug 30, 2024

tjclawson-stripe requested a review from jaynewstrom-stripe August 30, 2024 19:16

tjclawson-stripe added 2 commits September 4, 2024 12:32

Update API

53a9806

Merge branch 'master' into cvc-api-update

f06a744

tjclawson-stripe removed the DO-NOT-MERGE label Sep 4, 2024

Remove unused val

63152b7

jaynewstrom-stripe reviewed Sep 4, 2024

View reviewed changes

paymentsheet/api/paymentsheet.api Outdated Show resolved Hide resolved

jaynewstrom-stripe reviewed Sep 4, 2024

View reviewed changes

...tsheet/src/main/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowController.kt Show resolved Hide resolved

tjclawson-stripe added 3 commits September 4, 2024 16:42

Fix tests

ab39b73

API dump

0737608

Lint

f815735

jaynewstrom-stripe reviewed Sep 5, 2024

View reviewed changes

...et/src/test/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowControllerTest.kt Show resolved Hide resolved

Update CHANGELOG.md

4d14a77

tjclawson-stripe requested a review from jaynewstrom-stripe September 5, 2024 17:21

jaynewstrom-stripe reviewed Sep 5, 2024

View reviewed changes

Update CHANGELOG.md

4cb471f

Add analytics

ee6432b

tjclawson-stripe requested a review from jaynewstrom-stripe September 9, 2024 16:10

tjclawson-stripe added 3 commits September 9, 2024 12:56

Fix tests

d57491b

Lint

b7c60aa

remove logs

2bd1b57

jaynewstrom-stripe requested changes Sep 9, 2024

View reviewed changes

Revert analytics

2a79deb

tjclawson-stripe requested a review from jaynewstrom-stripe September 9, 2024 17:38

jaynewstrom-stripe approved these changes Sep 9, 2024

View reviewed changes

tjclawson-stripe merged commit 8821b19 into master Sep 9, 2024
13 checks passed

tjclawson-stripe deleted the cvc-api-update branch September 9, 2024 18:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CVC Recollection API for Deferred Intent flow #9158

Update CVC Recollection API for Deferred Intent flow #9158

tjclawson-stripe commented Aug 29, 2024

github-actions bot commented Aug 29, 2024 •

edited

Loading

jaynewstrom-stripe left a comment

jaynewstrom-stripe Sep 4, 2024

tjclawson-stripe Sep 4, 2024

jaynewstrom-stripe Sep 4, 2024

tjclawson-stripe Sep 5, 2024

emerge-tools bot commented Sep 5, 2024 •

edited

Loading

jaynewstrom-stripe Sep 5, 2024

tjclawson-stripe Sep 9, 2024

jaynewstrom-stripe Sep 9, 2024

tjclawson-stripe Sep 9, 2024

		@@ -2,6 +2,8 @@

		## XX.XX.XX - 20XX-XX-XX

		*[ADDED][9158](https://github.com/stripe/stripe-android/pull/9158) Add `requireCvcRecollection` param to `IntentConfiguration`

Update CVC Recollection API for Deferred Intent flow #9158

Update CVC Recollection API for Deferred Intent flow #9158

Conversation

tjclawson-stripe commented Aug 29, 2024

Summary

Motivation

Testing

Changelog

github-actions bot commented Aug 29, 2024 • edited Loading

jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emerge-tools bot commented Sep 5, 2024 • edited Loading

3 builds increased size

Stripe Identity Example 20.48.6-theme1 (20)com.stripe.android.identity.example.theme1

Financial Connections Example 20.48.6 (204806)com.stripe.android.financialconnections.example

PaymentSheet Example 20.48.6 (11)com.stripe.android.paymentsheet.example

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 29, 2024 •

edited

Loading

emerge-tools bot commented Sep 5, 2024 •

edited

Loading

Stripe Identity Example 20.48.6-theme1 (20)
com.stripe.android.identity.example.theme1

Financial Connections Example 20.48.6 (204806)
com.stripe.android.financialconnections.example

PaymentSheet Example 20.48.6 (11)
com.stripe.android.paymentsheet.example