-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass billing details in ElementsSessionContext
#9446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse output:
APK
DEX
|
tillh-stripe
force-pushed
the
tillh/instant-debits-billing-details
branch
2 times, most recently
from
October 16, 2024 20:44
7958cbe
to
1d58dc0
Compare
tillh-stripe
force-pushed
the
tillh/instant-debits-billing-details
branch
11 times, most recently
from
October 18, 2024 16:54
f8fb987
to
799f952
Compare
tillh-stripe
changed the base branch from
master
to
tillh/bank-billing-details-collection
October 18, 2024 16:54
tillh-stripe
force-pushed
the
tillh/instant-debits-billing-details
branch
from
October 18, 2024 19:20
799f952
to
e09b969
Compare
tillh-stripe
changed the base branch from
tillh/bank-billing-details-collection
to
tillh/link-card-brand-and-billing-details
October 18, 2024 19:21
Base automatically changed from
tillh/link-card-brand-and-billing-details
to
master
October 21, 2024 13:21
tillh-stripe
force-pushed
the
tillh/instant-debits-billing-details
branch
7 times, most recently
from
October 23, 2024 19:06
908f679
to
6beddeb
Compare
tillh-stripe
force-pushed
the
tillh/instant-debits-billing-details
branch
from
October 23, 2024 19:45
6beddeb
to
21bae0d
Compare
...ns/src/main/java/com/stripe/android/financialconnections/domain/CreateInstantDebitsResult.kt
Outdated
Show resolved
Hide resolved
...ipe/android/financialconnections/repository/FinancialConnectionsConsumerSessionRepository.kt
Outdated
Show resolved
Hide resolved
...in/java/com/stripe/android/financialconnections/repository/FinancialConnectionsRepository.kt
Outdated
Show resolved
Hide resolved
tillh-stripe
force-pushed
the
tillh/instant-debits-billing-details
branch
3 times, most recently
from
October 25, 2024 14:06
e2496f1
to
65ac9c8
Compare
1. Rename `BillingAddress` to `BillingDetails` and add email 2. Move extension to separate file and add comments 3. Remove duplicate `billing_phone` param
tillh-stripe
force-pushed
the
tillh/instant-debits-billing-details
branch
from
October 25, 2024 14:36
65ac9c8
to
2179a68
Compare
3 tasks
carlosmuvi-stripe
approved these changes
Oct 28, 2024
toluo-stripe
pushed a commit
that referenced
this pull request
Oct 29, 2024
* Pass billing address in `ElementsSessionContext` * Address code review feedback 1. Rename `BillingAddress` to `BillingDetails` and add email 2. Move extension to separate file and add comments 3. Remove duplicate `billing_phone` param * Put changes behind feature flag
mats-stripe
added a commit
to stripe/stripe-ios
that referenced
this pull request
Oct 29, 2024
…ails API (#4148) Android equivalent: stripe/stripe-android#9446 ## Summary This passes the billing address model and a billing email to the `/consumers/payment_details/` API. More details: https://docs.google.com/document/d/1IP66DkxVK6DzeGCmuw00Gt9okFhEHQgM3lqBZSA-M4E/edit?usp=sharing ## Motivation BANKCON-15711 ## Testing Unit tests, and I've verified the billing fields are correctly passed from MPE to the API call: <img width="1246" alt="Screenshot 2024-10-16 at 3 12 25 PM" src="https://github.com/user-attachments/assets/1d780fdd-bc69-45ba-9b22-0cf3f3295683"> ## Changelog N/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the billing address to the
ElementsSessionContext
, allowing us to pass it along when creating thePaymentMethod
in either the web or native view.Motivation
BANKCON-15709
Testing
Screenshots
Changelog