-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PaymentSheet Example app to compose 1.7.4. #9481
Conversation
Risky Change This is considered a risky change because it adjusts the sample app build.gradle, please review carefully. By adding the label |
Diffuse output:
APK
|
1 build increased size, 2 builds decreased size
Stripe Identity Example 20.52.1-theme1 (20)
|
Item | Install Size Change | Download Size Change |
---|---|---|
Other | ⬇️ 0 B | ⬇️ -1 B |
Financial Connections Example 20.52.1 (205201)
com.stripe.android.financialconnections.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 16 B
Total download size change: ⬇️ 973 B (-0.02%)
Largest size changes
Item | Install Size Change | Download Size Change |
---|---|---|
Other | ⬇️ -16 B | ⬇️ -973 B |
PaymentSheet Example 20.52.1 (11)
com.stripe.android.paymentsheet.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 214.3 kB (1.33%)
Total download size change: ⬆️ 108.1 kB (1.26%)
Largest size changes
Item | Install Size Change | Download Size Change |
---|---|---|
androidx.transition.FragmentTransitionSupport$1 | ⬇️ -49.7 kB | ⬇️ -22.7 kB |
📝 androidx.camera.core.impl.utils.MainThreadAsyncHandler | ⬆️ 42.8 kB | ⬆️ 19.6 kB |
📝 com.stripe.android.paymentsheet.ui.PaymentSheetScreenKt | ⬆️ 41.6 kB | ⬆️ 19.0 kB |
📝 com.stripe.android.paymentsheet.ui.PaymentMethodFormKt | ⬆️ 33.3 kB | ⬆️ 15.2 kB |
kotlin.math.MathKt | ⬇️ -30.9 kB | ⬇️ -14.1 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
352915d
to
fcb8849
Compare
Summary
We can't (easily) update the rest of the SDK to Compose 1.7, but we can (relatively) easily upgrade the end to end tests.
There's an issue with idling resources with compose 1.6 and our end to end tests. So this works around that.
Nightly run: https://github.com/stripe/stripe-android/actions/runs/11418764031