Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PaymentSheet Example app to compose 1.7.4. #9481

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Oct 19, 2024

Summary

We can't (easily) update the rest of the SDK to Compose 1.7, but we can (relatively) easily upgrade the end to end tests.

There's an issue with idling resources with compose 1.6 and our end to end tests. So this works around that.

Nightly run: https://github.com/stripe/stripe-android/actions/runs/11418764031

Copy link
Contributor

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

@jaynewstrom-stripe jaynewstrom-stripe added the accept-risky-change accept-risky-change label Oct 19, 2024
Copy link
Contributor

github-actions bot commented Oct 19, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.8 KiB │   6.8 KiB │  0 B 
    other │  90.3 KiB │  90.3 KiB │  0 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │  0 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20031 │ 20031 │ 0 (+0 -0) 
   types │  6196 │  6196 │ 0 (+0 -0) 
 classes │  4988 │  4988 │ 0 (+0 -0) 
 methods │ 30038 │ 30038 │ 0 (+0 -0) 
  fields │ 17549 │ 17549 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │  uncompressed   │                     
──────────┬──────┼──────────┬──────┤                     
 size     │ diff │ size     │ diff │ path                
──────────┼──────┼──────────┼──────┼─────────────────────
 28.5 KiB │ +1 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF  
  1.2 KiB │ -1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA 
──────────┼──────┼──────────┼──────┼─────────────────────
 29.6 KiB │  0 B │ 64.1 KiB │  0 B │ (total)

Copy link

emerge-tools bot commented Oct 19, 2024

1 build increased size, 2 builds decreased size

Name Version Download Change Install Change Approval
Stripe Identity Example
com.stripe.android.identity.example.theme1
20.52.1-theme1 (20) 3.8 MB ⬇️ 1 B 8.9 MB - N/A
Financial Connections Example
com.stripe.android.financialconnections.example
20.52.1 (205201) 4.2 MB ⬇️ 973 B (-0.02%) 9.5 MB ⬇️ 16 B N/A
PaymentSheet Example
com.stripe.android.paymentsheet.example
20.52.1 (11) 8.7 MB ⬆️ 108.1 kB (1.26%) 16.3 MB ⬆️ 214.3 kB (1.33%) N/A

Stripe Identity Example 20.52.1-theme1 (20)
com.stripe.android.identity.example.theme1

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: 0 B
Total download size change: ⬇️ 1 B

Largest size changes

Item Install Size Change Download Size Change
Other ⬇️ 0 B ⬇️ -1 B

Financial Connections Example 20.52.1 (205201)
com.stripe.android.financialconnections.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 16 B
Total download size change: ⬇️ 973 B (-0.02%)

Largest size changes

Item Install Size Change Download Size Change
Other ⬇️ -16 B ⬇️ -973 B

PaymentSheet Example 20.52.1 (11)
com.stripe.android.paymentsheet.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 214.3 kB (1.33%)
Total download size change: ⬆️ 108.1 kB (1.26%)

Largest size changes

Item Install Size Change Download Size Change
androidx.transition.FragmentTransitionSupport$1 ⬇️ -49.7 kB ⬇️ -22.7 kB
📝 androidx.camera.core.impl.utils.MainThreadAsyncHandler ⬆️ 42.8 kB ⬆️ 19.6 kB
📝 com.stripe.android.paymentsheet.ui.PaymentSheetScreenKt ⬆️ 41.6 kB ⬆️ 19.0 kB
📝 com.stripe.android.paymentsheet.ui.PaymentMethodFormKt ⬆️ 33.3 kB ⬆️ 15.2 kB
kotlin.math.MathKt ⬇️ -30.9 kB ⬇️ -14.1 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/compose-1.7.4-example branch from 352915d to fcb8849 Compare October 19, 2024 15:35
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review October 21, 2024 13:09
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners October 21, 2024 13:09
@jaynewstrom-stripe jaynewstrom-stripe merged commit d7a31c8 into master Oct 21, 2024
16 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/compose-1.7.4-example branch October 21, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accept-risky-change accept-risky-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants