-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimum length to AuBankAccountNumberConfig
#9576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samer-stripe
commented
Nov 8, 2024
return TextFieldStateConstants.Valid.Full | ||
} | ||
|
||
private companion object { | ||
const val LENGTH = 9 | ||
const val MINIMUM_LENGTH = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we would only enable a minimum length of 4 for Cuscal
but given that LUXE provides these fields separately and we have no way of currently observing other form field values, I haven't been able to think of a solution that doesn't either :
- Make major changes to element system to observe values coming from other elements.
- Makes static assumptions on an LPM's elements (ignore LUXE and make a custom
Element
to handle all of Becs similar toAddressElement
).
Diffuse output:
APK
DEX
|
jaynewstrom-stripe
approved these changes
Nov 8, 2024
wooj-stripe
added a commit
to stripe/stripe-ios
that referenced
this pull request
Nov 14, 2024
## Summary Mirrors change introduced here: stripe/stripe-android#9576 ## Motivation Au Becs can have a minimum of 5 digits (4 for Cuscal (BSB prefix 80)) however the SDK only allows for an account number with 9 digits. This PR allows for 4-5 digit account numbers for Becs. ## Testing Updated unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add minimum length to
AuBankAccountNumberConfig
.Motivation
Resolves https://jira.corp.stripe.com/browse/RUN_MOBILESDK-3682
Au Becs can have a minimum of 5 digits (4 for Cuscal (BSB prefix 80)) however the SDK only allows for an account number with 9 digits. This PR allows for 4-5 digit account numbers for Becs.
Testing