Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stripe-3ds2-android to version 6.2.0 #9672

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

tjclawson-stripe
Copy link
Collaborator

@tjclawson-stripe tjclawson-stripe commented Nov 19, 2024

Summary

Update stripe-3ds2-android to version 6.2.0

Motivation

Update to new 3ds 2.2 spec

Testing

  • Added tests
  • Modified tests
  • Manually verified

@tjclawson-stripe tjclawson-stripe requested review from a team as code owners November 19, 2024 22:41
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed             │           uncompressed           
          ├───────────┬───────────┬───────────┼───────────┬──────────┬───────────
 APK      │ old       │ new       │ diff      │ old       │ new      │ diff      
──────────┼───────────┼───────────┼───────────┼───────────┼──────────┼───────────
      dex │   3.9 MiB │   3.9 MiB │ +28.2 KiB │   8.4 MiB │  8.5 MiB │ +66.2 KiB 
     arsc │   2.3 MiB │   2.3 MiB │    +864 B │   2.3 MiB │  2.3 MiB │    +864 B 
 manifest │     5 KiB │     5 KiB │       0 B │  24.9 KiB │ 24.9 KiB │       0 B 
      res │ 902.2 KiB │ 904.1 KiB │  +1.8 KiB │   1.4 MiB │  1.4 MiB │    +6 KiB 
   native │   2.6 MiB │   2.6 MiB │       0 B │     6 MiB │    6 MiB │       0 B 
    asset │   1.6 MiB │   1.6 MiB │     +14 B │   1.6 MiB │  1.6 MiB │     +14 B 
    other │ 199.8 KiB │   1.4 MiB │  +1.2 MiB │ 440.1 KiB │  1.6 MiB │  +1.2 MiB 
──────────┼───────────┼───────────┼───────────┼───────────┼──────────┼───────────
    total │  11.4 MiB │  12.6 MiB │  +1.2 MiB │  20.2 MiB │ 21.5 MiB │  +1.2 MiB 

 DEX     │ old   │ new   │ diff                 
─────────┼───────┼───────┼──────────────────────
   files │     1 │     1 │    0                 
 strings │ 39873 │ 40334 │ +461 (+4643 -4182)   
   types │ 13758 │ 13905 │ +147 (+4087 -3940)   
 classes │ 11450 │ 11596 │ +146 (+3319 -3173)   
 methods │ 58745 │ 59237 │ +492 (+28932 -28440) 
  fields │ 39049 │ 39510 │ +461 (+21830 -21369) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  242 │  243 │ +1 (+1 -0) 
 entries │ 6194 │ 6194 │  0 (+2 -2)
APK
       compressed       │      uncompressed      │                                                               
───────────┬────────────┼───────────┬────────────┤                                                               
 size      │ diff       │ size      │ diff       │ path                                                          
───────────┼────────────┼───────────┼────────────┼───────────────────────────────────────────────────────────────
 731.9 KiB │ +731.9 KiB │   735 KiB │   +735 KiB │ + org/bouncycastle/pqc/crypto/picnic/lowmcL5.bin.properties   
 340.2 KiB │ +340.2 KiB │ 341.9 KiB │ +341.9 KiB │ + org/bouncycastle/pqc/crypto/picnic/lowmcL3.bin.properties   
 114.8 KiB │ +114.8 KiB │ 115.5 KiB │ +115.5 KiB │ + org/bouncycastle/pqc/crypto/picnic/lowmcL1.bin.properties   
   3.9 MiB │  +28.2 KiB │   8.5 MiB │  +66.2 KiB │ ∆ classes.dex                                                 
     918 B │     +918 B │   2.8 KiB │   +2.8 KiB │ + res/wi.xml                                                  
     901 B │     +901 B │   2.8 KiB │   +2.8 KiB │ + res/uG.xml                                                  
   2.3 MiB │     +864 B │   2.3 MiB │     +864 B │ ∆ resources.arsc                                              
     389 B │     +389 B │     464 B │     +464 B │ + res/color/stripe_info_zone_header_text.xml                  
           │     -375 B │           │     -464 B │ - res/color/info_zone_header_text.xml                         
  53.3 KiB │     +289 B │ 118.1 KiB │     +558 B │ ∆ META-INF/CERT.SF                                            
    50 KiB │     +257 B │   118 KiB │     +558 B │ ∆ META-INF/MANIFEST.MF                                        
     127 B │     +127 B │       5 B │       +5 B │ + META-INF/services/C9.x                                      
     127 B │     +127 B │       5 B │       +5 B │ + META-INF/services/D9.a                                      
           │     -127 B │           │       -5 B │ - META-INF/services/A9.a                                      
           │     -127 B │           │       -5 B │ - META-INF/services/z9.v                                      
   7.8 KiB │      +32 B │   7.7 KiB │      +32 B │ ∆ assets/dexopt/baseline.prof                                 
   1,007 B │      -18 B │     875 B │      -18 B │ ∆ assets/dexopt/baseline.profm                                
     839 B │      +10 B │   2.6 KiB │     +180 B │ ∆ res/G9.xml                                                  
     818 B │      +10 B │   2.5 KiB │     +180 B │ ∆ res/Ql.xml                                                  
     965 B │       +4 B │   2.7 KiB │        0 B │ ∆ res/ZW.xml                                                  
     539 B │       +2 B │     952 B │        0 B │ ∆ res/zd.xml                                                  
     272 B │       +1 B │     120 B │        0 B │ ∆ META-INF/version-control-info.textproto                     
     811 B │       -1 B │   2.3 KiB │        0 B │ ∆ res/1w.xml                                                  
   1.2 KiB │       +1 B │   3.9 KiB │        0 B │ ∆ res/2d.xml                                                  
     765 B │       +1 B │   1.9 KiB │        0 B │ ∆ res/2f.xml                                                  
     750 B │       +1 B │   1.5 KiB │        0 B │ ∆ res/3O.xml                                                  
     443 B │       -1 B │     816 B │        0 B │ ∆ res/3h.xml                                                  
     850 B │       +1 B │   1.8 KiB │        0 B │ ∆ res/8Q.xml                                                  
     742 B │       -1 B │   1.5 KiB │        0 B │ ∆ res/9V.xml                                                  
     763 B │       -1 B │   1.6 KiB │        0 B │ ∆ res/A0.xml                                                  
   1.2 KiB │       +1 B │   3.7 KiB │        0 B │ ∆ res/BH.xml                                                  
     932 B │       +1 B │   2.6 KiB │        0 B │ ∆ res/Be.xml                                                  
     785 B │       +1 B │   1.6 KiB │        0 B │ ∆ res/Bh.xml                                                  
     619 B │       -1 B │   1.3 KiB │        0 B │ ∆ res/Io.xml                                                  
     519 B │       +1 B │     1 KiB │        0 B │ ∆ res/Lx.xml                                                  
     380 B │       -1 B │     628 B │        0 B │ ∆ r
...✂
DEX
STRINGS:

   old   │ new   │ diff               
  ───────┼───────┼────────────────────
   39873 │ 40334 │ +461 (+4643 -4182) 
  
  + 
  See 
  + 
  [
  +     public data: 
  +  API 
  +  Private Key [
  +  Public Key [
  +  accessible; either increase its visibility or write a custom TypeAdapter for its declaring type.
  +  declared by 
  +  declares multiple JSON fields named '
  +  does not satisfy bounds for type variable 
  +  is not a valid JSON number: 
  +  is not a valid double value as per JSON specification. To override this behavior, use GsonBuilder.serializeSpecialFloatingPointValues() method.
  +  is not accessible and ReflectionAccessFilter does not permit making it accessible. Register a TypeAdapter for the declaring type, adjust the access filter or increase the visibility of the element and its declaring type.
  +  is not an array of strings
  +  is not supported because it requires specifying an owner type
  +  is not supported for Crystals Kyber
  +  is prohibited after the pad character
  +  must be at least 
  +  not a valid OID
  +  not a valid relative OID
  +  not supported for SHAKE
  +  tag but found 
  +  threw exception
  +  to byte; at path 
  +  to short; at path 
  +  type arguments, but got 2
  + #1C
  + ' accessible; either increase its visibility or write a custom InstanceCreator or TypeAdapter for its declaring type: 
  + ' as BigDecimal; at path 
  + ' as BigInteger; at path 
  + ' as Currency; at path 
  + ' as Date; at path 
  + ' as SQL Date; at path 
  + ' as SQL Time; at path 
  + ' as UUID; at path 
  + ' for field with name '
  + ' of primitive type; at path 
  + ' with args 
  + ' with no args
  + '(
  + ', unable to determine which argument in the constructor the field corresponds to. This is unexpected behavior, as we expect the RecordComponents to have the same names as the fields in the Java class, and that the order of the RecordComponents is the same as the order of the canonical constructor parameters.
  + '; conflict is caused by fields 
  + 'bitStrength' 
  + 'contents' cannot be null
  + ) at index 
  + , expected 0 or 1; at path 
  + , whitelistingDataEntry=
  + , whitelistingValue=
  + ,factories:
  + -?(?:0|[1-9][0-9]*)(?:\.[0-9]+)?(?:[eE][-+]?[0-9]+)?
  + . Forgot to register a type adapter?
  See 
  + . Registering an InstanceCreator or a TypeAdapter for this type, or adding a no-args constructor may fix this problem.
  + . Usage of JDK sun.misc.Unsafe is enabled, but it could not be used. Make sure your runtime is configured correctly.
  + 1.3.6.1.4.1.2.267.11.4.4
  + 1.3.6.1.4.1.2.267.11.6.5
  + 1.3.6.1.4.1.2.267.11.8.7
  + 1.3.6.1.4.1.2.267.12.4.4
  + 1.3.6.1.4.1.2.267.12.6.5
  + 1.3.6.1.4.1.2.267.12.8.7
  + 1.3.9999.3.6
  + 1.3.9999.3.9
  + 1.3.9999.6
  + 1.3.9999.6.4.10
  + 1.3.9999.6.4.13
  + 1.3.9999.6.4.16
  + 1.3.9999.6.5.10
  + 1.3.9999.6.5.12
  + 1.3.9999.6.6.10
  + 1.3.9999.6.6.12
  + 1.3.9999.6.7.13
  + 1.3.9999.6.7.16
  + 1.3.9999.6.8.10
  + 1.3.9999.6.8.12
  + 1.3.9999.6.9.10
  + 1.3.9999.6.9.12
  + 1.6
  + 2.16.840.1.114027.80.5.1.1
  + 2.16.840.1.114027.80.5.1.10
  + 2.16.840.1.114027.80.5.1.2
  + 2.16.840.1.114027.80.5.1.3
  + 2.16.840.1.114027.80.5.1.4
  + 2.16.840.1.114027.80.5.1.5
  + 2.16.840.1.114027.80.5.1.6
  + 2.16.840.1.114027.80.5.1.7
  + 2.16.840.1.114027.80.5.1.8
  + 2.16.840.1.114027.80.5.1.9
  + 30470ad5a005fb14ce2d9dcd87e38bc7d1b1c5facbaecbe95f190aa7a31d23c4dbbcbe06174544401a5b2c020965d8c2bd2171d3668445771f74ba084d2029d83c1c158547f3a9f1a2715be23d51ae4d3e5a1f6a7064f316933a346d3f529252
  + 32
  + 36
  + 39
  + 3DS_LOA_SDK_STIN_020200_00960
  + 42debb9da5b3d88cc956e08787ec3f3a09bba5f48b889a74aaf53174aa0fbe7e3c5b8fcd7a53bef563b0e98560328960a9517f4014d3325fc7962bf1e049370d76d1314a76137e792f3f0db859d095e4a5b932024f079ecf2ef09c797452b0770e1350782ed57ddf794979dcef23cb96f183061965c4ebc93c9c71c56b925955a75f94cccf1449ac43d586d0beee43251b0b2287349d68de0d144403f13e802f4146d882e057af19b6f6275c6676c8fa0e3ca2713a3257fd1b27d0639f695e347d8d1cf9ac819a26ca9b04cb0eb9b7b035988d15bbac65212a55239cfc7e58fae38d7250ab9991ffbc97134025fe8ce04c4399ad96569be91a546f4978693c7a
  + 49
  + 678471b27a9cf44ee91a49c5147db1a9aaf244f05a434d6486931d2d14271b9e35030b71fd73da179069b32e2935630e1c2062354d0da20a6c416e50be794ca4
  + 77d0f8c4dad15eb8c4f2f8d6726cefd96d5bb399
  + 8d5155894229d5e689ee01e6018a237e2cae64cd
  + 95475cf5d93e596c3fcd1d902add02f427f5f3c7210313bb45fb4d5bb2e5fe1cbd678cd4bbdd84c9836be1f31c0777725aeb6c2fc38b85f48076fa76bcd8146cc89a6fb2f706dd719898c2083d
...✂
ARSC
CONFIGS:

   old │ new │ diff       
  ─────┼─────┼────────────
   242 │ 243 │ +1 (+1 -0) 
  + layout-land-v22
  

ENTRIES:

   old  │ new  │ diff      
  ──────┼──────┼───────────
   6194 │ 6194 │ 0 (+2 -2) 
  + color/stripe_info_zone_header_text
  + id/czv_info_label
  
  - color/info_zone_header_text
  - string/attach_default_billing_address

Copy link

emerge-tools bot commented Nov 19, 2024

2 builds increased size, 1 build decreased size

Name Version Download Change Install Change Approval
Stripe Identity Example
com.stripe.android.identity.example.theme1
21.1.0-theme1 (20) 3.8 MB ⬇️ 2 B 8.9 MB - N/A
⚠️ Financial Connections Example
com.stripe.android.financialconnections.example
21.1.0 (210100) 5.4 MB ⬆️ 1.2 MB (29.82%) 10.6 MB ⬆️ 1.3 MB (13.84%) N/A
⚠️ PaymentSheet Example
com.stripe.android.paymentsheet.example
21.1.0 (11) 8.4 MB ⬆️ 1.2 MB (17.47%) 15.7 MB ⬆️ 1.3 MB (8.98%) N/A

Stripe Identity Example 21.1.0-theme1 (20)
com.stripe.android.identity.example.theme1

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: 0 B
Total download size change: ⬇️ 2 B

Largest size changes

Item Install Size Change Download Size Change
Other ⬇️ 0 B ⬇️ -2 B

Financial Connections Example 21.1.0 (210100)
com.stripe.android.financialconnections.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 1.3 MB (13.84%)
Total download size change: ⬆️ 1.2 MB (29.82%)

Largest size changes

Item Install Size Change Download Size Change
📝 lowmcL5.bin.properties ⬆️ 749.3 kB ⬆️ 749.3 kB
📝 lowmcL3.bin.properties ⬆️ 348.2 kB ⬆️ 348.2 kB
📝 lowmcL1.bin.properties ⬆️ 117.4 kB ⬆️ 117.4 kB
🗑 com.nimbusds.jose.shaded.ow2asm ⬇️ -102.9 kB ⬇️ -48.4 kB
🗑 com.nimbusds.jose.shaded.asm ⬇️ -56.2 kB ⬇️ -26.5 kB
View Treemap

Image of diff

PaymentSheet Example 21.1.0 (11)
com.stripe.android.paymentsheet.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 1.3 MB (8.98%)
Total download size change: ⬆️ 1.2 MB (17.47%)

Largest size changes

Item Install Size Change Download Size Change
📝 lowmcL5.bin.properties ⬆️ 749.3 kB ⬆️ 749.3 kB
📝 lowmcL3.bin.properties ⬆️ 348.2 kB ⬆️ 348.2 kB
📝 lowmcL1.bin.properties ⬆️ 117.4 kB ⬆️ 117.4 kB
🗑 com.nimbusds.jose.shaded.ow2asm ⬇️ -134.6 kB ⬇️ -61.5 kB
📝 androidx.compose.foundation.text.selection.SelectionManagerKt ⬆️ 65.4 kB ⬆️ 29.9 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@tjclawson-stripe tjclawson-stripe requested review from a team as code owners November 19, 2024 23:05
@tjclawson-stripe tjclawson-stripe enabled auto-merge (squash) November 20, 2024 00:32
@tjclawson-stripe tjclawson-stripe merged commit 90be5f8 into master Nov 20, 2024
17 checks passed
@tjclawson-stripe tjclawson-stripe deleted the tyler/update-3ds2 branch November 20, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants