Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instant_or_skip verification for ACH #9695

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Nov 22, 2024

Summary

This pull request adds support for the instant_or_skip verification method for US bank accounts, and follows the iOS change to also show the correct mandate (without a microdeposits disclaimer) for these cases.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │  0 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │  0 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │  uncompressed   │                        
──────────┬──────┼──────────┬──────┤                        
 size     │ diff │ size     │ diff │ path                   
──────────┼──────┼──────────┼──────┼────────────────────────
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
 25.3 KiB │ -1 B │ 62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼──────────┼──────┼────────────────────────
 26.5 KiB │  0 B │ 64.1 KiB │  0 B │ (total)

@tillh-stripe tillh-stripe force-pushed the tillh/manual-entry-microdeposits-fix branch from 16e7772 to 3ed4818 Compare November 22, 2024 16:32
@tillh-stripe tillh-stripe force-pushed the tillh/manual-entry-microdeposits-fix branch 3 times, most recently from 455f21a to 4b20e07 Compare November 22, 2024 19:38
Introduce `FinancialConnectionsSheetInternalResult` and a `toPublicResult` method
@tillh-stripe tillh-stripe force-pushed the tillh/manual-entry-microdeposits-fix branch from 4b20e07 to 00a8114 Compare November 22, 2024 20:16
@tillh-stripe tillh-stripe force-pushed the tillh/manual-entry-microdeposits-fix branch 2 times, most recently from df8ba60 to a208f9e Compare November 25, 2024 20:34
@tillh-stripe tillh-stripe force-pushed the tillh/manual-entry-microdeposits-fix branch from a208f9e to fa6b6eb Compare November 25, 2024 20:52
@tillh-stripe tillh-stripe marked this pull request as ready for review November 25, 2024 21:22
@tillh-stripe tillh-stripe requested review from a team as code owners November 25, 2024 21:22
@tillh-stripe tillh-stripe merged commit 4a18fb4 into master Nov 28, 2024
13 checks passed
@tillh-stripe tillh-stripe deleted the tillh/manual-entry-microdeposits-fix branch November 28, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants