Better handle process death for all confirmation flow cases in `DefaultConfirmationHandler` #9754

samer-stripe · 2024-12-06T00:14:59Z

Summary

Better handle process death for all confirmation flow cases in DefaultConfirmationHandler.

Motivation

Our current process death handling works fine when a result is received in process but not great when a result is not received in process and results in a next step action

Testing

Added tests
Modified tests
Manually verified

github-actions · 2024-12-06T00:21:10Z

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ +4 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +4 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0

APK

   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 28.4 KiB │ +4 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    271 B │ -1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 29.9 KiB │ +4 B │ 64.2 KiB │  0 B │ (total)

…ltConfirmationHandler`

samer-stripe · 2024-12-06T00:22:37Z

...t/src/main/java/com/stripe/android/paymentelement/confirmation/DefaultConfirmationHandler.kt

@@ -142,6 +145,7 @@ internal class DefaultConfirmationHandler(
        when (val action = mediator.action(confirmationOption, intent)) {
            is ConfirmationMediator.Action.Launch -> {
                storeIsAwaitingForResult(
+                    key = mediator.key,


I imagine we never will have a case like this but if we ever decide that the same definition can be looped through multiple times in a confirmation flow, this will break. Other option to use UUID instead.

Feels like a fine trade off for now 👍

jaynewstrom-stripe · 2024-12-06T12:37:45Z

...t/src/main/java/com/stripe/android/paymentelement/confirmation/DefaultConfirmationHandler.kt

@@ -142,6 +145,7 @@ internal class DefaultConfirmationHandler(
        when (val action = mediator.action(confirmationOption, intent)) {
            is ConfirmationMediator.Action.Launch -> {
                storeIsAwaitingForResult(
+                    key = mediator.key,


Feels like a fine trade off for now 👍

…ltConfirmationHandler` (#9754)

* Initial camera implementation # Conflicts: # connect-example/src/main/java/com/stripe/android/connect/example/ui/features/payouts/PayoutsExampleActivity.kt # connect/src/main/java/com/stripe/android/connect/PayoutsView.kt # Conflicts: # connect/src/main/java/com/stripe/android/connect/PayoutsView.kt # connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewClient.kt # Conflicts: # connect-example/src/main/java/com/stripe/android/connect/example/ui/features/payouts/PayoutsExampleActivity.kt # connect/src/main/java/com/stripe/android/connect/EmbeddedComponentManager.kt # connect/src/main/java/com/stripe/android/connect/PayoutsView.kt * Update request code * Update example activity * Refactor permission, handle within manager * Fix leftover merge conflicts # Conflicts: # connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewContainer.kt * WIP * Fix merge * Fix build issues * fix activity * Fix suspend function * refactor with activity oncreate * Show promo badge in bank form (#9734) * Show promo badge in bank form * Address code review feedback Fix layout issue with super-long bank name and validate with screenshot test. * Add Embedded Appearance params to AppearanceBottomSheetDialogFragment (#9727) * Add Embedded Appearance params to AppearanceBottomSheetDialogFragment * [MOBILESDK-2480]update text style for bacs secondary button type (#9745) * update text style for bacs secondary button type * screenshots for screenshot tests * Apply suggestions from code review Capitalize comment and add period Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com> * crypto payment method (#9753) * Better handle process death for all confirmation flow cases in `DefaultConfirmationHandler` (#9754) * Fix lints, remove unneeded cancellation function * Add tests * Fix tests * Add/fix logging * Fix lint from log line * Fix main thread * Update connect/src/main/java/com/stripe/android/connect/webview/StripeConnectWebViewContainer.kt Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com> * Update connect/src/main/java/com/stripe/android/connect/EmbeddedComponentManager.kt Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com> * unsupported behavior to log warning * Fix docstrings * Update crashing behavior for camera permission request * Move functions around for clarity * Update tests * Update and fix tests * Fix detekt lints * Fix main activity * Remove unnecessary fragment, move logger out of constructor * Clean up lib restriction * Remove unnecessary unconfined test dispatcher * Update api * Lint fixes --------- Co-authored-by: Till Hellmund <tillh@stripe.com> Co-authored-by: tjclawson-stripe <163896025+tjclawson-stripe@users.noreply.github.com> Co-authored-by: Tian Zhao <tianzhao@stripe.com> Co-authored-by: Bella Koch <160939932+amk-stripe@users.noreply.github.com> Co-authored-by: ericzhang-stripe <94195995+ericzhang-stripe@users.noreply.github.com> Co-authored-by: Samer Alabi <141707240+samer-stripe@users.noreply.github.com> Co-authored-by: lng-stripe <91862945+lng-stripe@users.noreply.github.com>

samer-stripe force-pushed the samer/refactor-process-death-handling-in-confirmation branch from a14e30e to 4c534c7 Compare December 6, 2024 00:20

Better handle process death for all confirmation flow cases in `Defau…

df88d90

…ltConfirmationHandler`

samer-stripe force-pushed the samer/refactor-process-death-handling-in-confirmation branch from 4c534c7 to df88d90 Compare December 6, 2024 00:21

samer-stripe commented Dec 6, 2024

View reviewed changes

samer-stripe marked this pull request as ready for review December 6, 2024 04:59

samer-stripe requested review from a team as code owners December 6, 2024 04:59

samer-stripe requested a review from tjclawson-stripe December 6, 2024 04:59

samer-stripe added the embedded-confirmation Related to Embedded project in terms of confirmation work label Dec 6, 2024

jaynewstrom-stripe approved these changes Dec 6, 2024

View reviewed changes

samer-stripe merged commit 2b36058 into master Dec 6, 2024
13 checks passed

samer-stripe deleted the samer/refactor-process-death-handling-in-confirmation branch December 6, 2024 16:04

simond-stripe pushed a commit that referenced this pull request Dec 6, 2024

Better handle process death for all confirmation flow cases in `Defau…

1fca7e4

…ltConfirmationHandler` (#9754)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better handle process death for all confirmation flow cases in `DefaultConfirmationHandler` #9754

Better handle process death for all confirmation flow cases in `DefaultConfirmationHandler` #9754

samer-stripe commented Dec 6, 2024

github-actions bot commented Dec 6, 2024 •

edited

Loading

samer-stripe Dec 6, 2024

jaynewstrom-stripe Dec 6, 2024

jaynewstrom-stripe Dec 6, 2024

Better handle process death for all confirmation flow cases in DefaultConfirmationHandler #9754

Better handle process death for all confirmation flow cases in DefaultConfirmationHandler #9754

Conversation

samer-stripe commented Dec 6, 2024

Summary

Motivation

Testing

github-actions bot commented Dec 6, 2024 • edited Loading

samer-stripe Dec 6, 2024

Choose a reason for hiding this comment

jaynewstrom-stripe Dec 6, 2024

Choose a reason for hiding this comment

jaynewstrom-stripe Dec 6, 2024

Choose a reason for hiding this comment

Better handle process death for all confirmation flow cases in `DefaultConfirmationHandler` #9754

Better handle process death for all confirmation flow cases in `DefaultConfirmationHandler` #9754

github-actions bot commented Dec 6, 2024 •

edited

Loading