Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connect] Default to using the first account if no account is selected #9783

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

simond-stripe
Copy link
Collaborator

Summary

To make things easier for testing, if you haven't selected an account you should get the first account in the EmbeddedComponents

Motivation

This makes the example app easier to use and test

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

After

demo-1734112279.mp4

Before

demo-1734112581.mp4

@simond-stripe simond-stripe requested a review from a team as a code owner December 13, 2024 17:58
@simond-stripe simond-stripe enabled auto-merge (squash) December 13, 2024 17:58
Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │   0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │   0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │   0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.3 KiB │  90.2 KiB │ -11 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -11 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
    compressed    │  uncompressed   │                                           
──────────┬───────┼──────────┬──────┤                                           
 size     │ diff  │ size     │ diff │ path                                      
──────────┼───────┼──────────┼──────┼───────────────────────────────────────────
 28.5 KiB │  -7 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    270 B │  -2 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │  -2 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼───────┼──────────┼──────┼───────────────────────────────────────────
 29.9 KiB │ -11 B │ 64.2 KiB │  0 B │ (total)

@simond-stripe simond-stripe merged commit e026848 into master Dec 13, 2024
13 checks passed
@simond-stripe simond-stripe deleted the simond/connect-sdk-example-fixes branch December 13, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants