Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach backport. #9803

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Dec 18, 2024

Summary

This cherry picks #9800 and #9801 back to 20.52.0

The cherry pick was not clean.

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   1.9 MiB │   1.9 MiB │  0 B │     4 MiB │     4 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.8 KiB │   6.8 KiB │  0 B │   6.6 KiB │   6.6 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │ -9 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.5 MiB │   9.5 MiB │ -9 B │  21.4 MiB │  21.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20252 │ 20252 │ 0 (+0 -0) 
   types │  6082 │  6082 │ 0 (+0 -0) 
 classes │  4886 │  4886 │ 0 (+0 -0) 
 methods │ 29463 │ 29463 │ 0 (+0 -0) 
  fields │ 17389 │ 17389 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3608 │ 3608 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 28.3 KiB │ -7 B │  62.6 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.1 KiB │ -2 B │  62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼───────────┼──────┼────────────────────────
 53.4 KiB │ -9 B │ 125.1 KiB │  0 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/detach-backport branch from defbce6 to ba14c46 Compare December 18, 2024 18:56
@jaynewstrom-stripe jaynewstrom-stripe changed the base branch from release/20.53.0 to release/20.52 December 18, 2024 18:56
@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/detach-backport branch from ba14c46 to 38fdadf Compare December 19, 2024 18:03
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review December 19, 2024 18:36
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners December 19, 2024 18:36
@jaynewstrom-stripe jaynewstrom-stripe requested review from amk-stripe and removed request for a team December 19, 2024 18:36
@jaynewstrom-stripe jaynewstrom-stripe merged commit a4f34c5 into release/20.52 Dec 19, 2024
11 of 13 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/detach-backport branch December 19, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants