Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PaymentMethodEmbeddedLayoutUI #9808

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tjclawson-stripe
Copy link
Collaborator

@tjclawson-stripe tjclawson-stripe commented Dec 19, 2024

Summary

Add PaymentMethodEmbeddedLayoutUI

Motivation

MOBILESDK-2851

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
image image

Changelog

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ +7 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +7 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │  uncompressed   │                        
──────────┬──────┼──────────┬──────┤                        
 size     │ diff │ size     │ diff │ path                   
──────────┼──────┼──────────┼──────┼────────────────────────
 25.3 KiB │ +4 B │ 62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
 28.5 KiB │ +2 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF     
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼──────────┼──────┼────────────────────────
 54.9 KiB │ +7 B │  127 KiB │  0 B │ (total)

@tjclawson-stripe tjclawson-stripe changed the title Update PaymentMethodVerticalLayoutUI for Embedded Add PaymentMethodEmbeddedLayoutUI Dec 19, 2024
@tjclawson-stripe tjclawson-stripe marked this pull request as ready for review December 19, 2024 20:58
@tjclawson-stripe tjclawson-stripe requested review from a team as code owners December 19, 2024 20:58
@tjclawson-stripe
Copy link
Collaborator Author

Will remove rowType from PaymentMethodVerticalLayoutInteractor.State in a follow up PR

@@ -47,7 +47,7 @@ class PaymentMethodEmbeddedLayoutUIScreenshotTest {
onSelectSavedPaymentMethod = {},
onManageOneSavedPaymentMethod = {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually thinking a bit about the reverse. I thought all of the fields outside of row style were the same. And row style was the only "difference".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about both? Added TestPaymentMethodLayoutUi helper function

if (rowStyle.hasSeparators()) {
val color = Color(rowStyle.separatorColor())
val thickness = rowStyle.separatorThickness()
val modifier = if (rowStyle is Embedded.RowStyle.FlatWithRadio) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like another one we should move into rowStyle.

import org.robolectric.RobolectricTestRunner
import org.robolectric.annotation.Config

@RunWith(RobolectricTestRunner::class)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary, and is deceptive! This isn't actually running any tests, but is a helper!

@RunWith(RobolectricTestRunner::class)
@Config(sdk = [Build.VERSION_CODES.Q])
@OptIn(ExperimentalEmbeddedPaymentElementApi::class)
class PaymentMethodLayoutUITestHelper(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach might not be ideal.

It would be easy to add another scenario, but miss adding it for both variants. Maybe we should have a shared test for both, driven by parameterized tests. That would ensure we couldn't miss a test case for the common case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants