-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC] Prepares integrity on first sync call #9818
Open
carlosmuvi-stripe
wants to merge
1
commit into
carlosmuvi/12-21-adds-activity-retained-scope
Choose a base branch
from
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
base: carlosmuvi/12-21-adds-activity-retained-scope
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[FC] Prepares integrity on first sync call #9818
carlosmuvi-stripe
wants to merge
1
commit into
carlosmuvi/12-21-adds-activity-retained-scope
from
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Diffuse output:
APK
|
This was referenced Dec 21, 2024
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
2 times, most recently
from
December 23, 2024 11:52
706894d
to
04b27ef
Compare
carlosmuvi-stripe
changed the title
F
[FC] Adds ActivityRetainedScope and broader singleton component
Dec 23, 2024
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
2 times, most recently
from
December 23, 2024 12:12
69c825d
to
1f9ede2
Compare
carlosmuvi-stripe
changed the base branch from
master
to
carlosmuvi/12-21-adds-activity-retained-scope
December 23, 2024 12:12
3 tasks
carlosmuvi-stripe
changed the title
[FC] Adds ActivityRetainedScope and broader singleton component
[FC] Prepares integrity on first sync call
Dec 23, 2024
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 23, 2024 12:17
1f9ede2
to
f49fde3
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-adds-activity-retained-scope
branch
from
December 23, 2024 14:22
5c4c9af
to
cc8fb23
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
2 times, most recently
from
December 23, 2024 14:28
1840272
to
ef32d6f
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-adds-activity-retained-scope
branch
from
December 24, 2024 13:08
cc8fb23
to
fa975d8
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 24, 2024 13:08
ef32d6f
to
8b718ff
Compare
carlosmuvi-stripe
requested review from
samer-stripe
and removed request for
a team
December 25, 2024 10:57
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-adds-activity-retained-scope
branch
from
December 25, 2024 11:00
fa975d8
to
81df1b9
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 25, 2024 11:00
9be7b86
to
67af8e1
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Call
Integrity#prepare
on Activity A (FinancialConnectionsSheetActivity
) and reuse the same Integrity instance in Activity B (FinancialConnectionsNativeActivity
) when generating tokens.Motivation
https://docs.google.com/document/d/1joKz5UZHLVazmecfMHbq6gB6n4wj5u8To6AtqYgq_tc/edit?tab=t.0#heading=h.cz1xkpga7giy
Testing