Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crypto from PaymentSheet. #9822

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Dec 23, 2024

Summary

This hasn't gone through the launch approval process yet, so rolling it back for now.

Originally introduced in #9753

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼──────────┬──────────┬──────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff     
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
      dex │   3.9 MiB │   3.9 MiB │    +43 B │  8.6 MiB │  8.6 MiB │   -548 B 
     arsc │   2.2 MiB │   2.2 MiB │   -896 B │  2.2 MiB │  2.2 MiB │   -896 B 
 manifest │     5 KiB │     5 KiB │      0 B │ 24.9 KiB │ 24.9 KiB │      0 B 
      res │ 908.2 KiB │ 906.3 KiB │ -1.9 KiB │  1.4 MiB │  1.4 MiB │ -3.3 KiB 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │ -1.4 KiB │  1.6 MiB │  1.6 MiB │ -1.4 KiB 
    other │   1.4 MiB │   1.4 MiB │   -299 B │  1.6 MiB │  1.6 MiB │ -1.3 KiB 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
    total │  12.6 MiB │  12.6 MiB │ -4.4 KiB │ 21.5 MiB │ 21.5 MiB │ -7.4 KiB 

 DEX     │ old   │ new   │ diff         
─────────┼───────┼───────┼──────────────
   files │     1 │     1 │  0           
 strings │ 40596 │ 40595 │ -1 (+1 -2)   
   types │ 14009 │ 14008 │ -1 (+0 -1)   
 classes │ 11683 │ 11682 │ -1 (+0 -1)   
 methods │ 59622 │ 59616 │ -6 (+15 -21) 
  fields │ 39810 │ 39806 │ -4 (+7 -11)  

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  243 │  243 │  0         
 entries │ 6209 │ 6207 │ -2 (+0 -2)
APK
     compressed      │     uncompressed     │                               
──────────┬──────────┼───────────┬──────────┤                               
 size     │ diff     │ size      │ diff     │ path                          
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  6.4 KiB │ -1.4 KiB │   6.3 KiB │ -1.4 KiB │ ∆ assets/dexopt/baseline.prof 
          │   -968 B │           │ -1.6 KiB │ - res/NR.xml                  
          │   -963 B │           │ -1.6 KiB │ - res/XF.xml                  
  2.2 MiB │   -896 B │   2.2 MiB │   -896 B │ ∆ resources.arsc              
  3.5 KiB │   -132 B │  28.6 KiB │ -1,018 B │ ∆ lpms.json                   
 50.1 KiB │    -85 B │ 118.3 KiB │   -164 B │ ∆ META-INF/MANIFEST.MF        
 53.4 KiB │    -81 B │ 118.3 KiB │   -164 B │ ∆ META-INF/CERT.SF            
  3.9 MiB │    +43 B │   8.6 MiB │   -548 B │ ∆ classes.dex                 
    879 B │     -1 B │   2.3 KiB │      0 B │ ∆ res/YB.xml                  
  1.2 KiB │     -1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA           
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  6.3 MiB │ -4.4 KiB │  11.1 MiB │ -7.4 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   40596 │ 40595 │ -1 (+1 -2) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"455f645","r8-mode":"full","version":"8.7.14"}
  
  - LG6/P;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"a79a7a8","r8-mode":"full","version":"8.7.14"}
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   14009 │ 14008 │ -1 (+0 -1) 
  
  - LG6/P;
  

METHODS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   59622 │ 59616 │ -6 (+15 -21) 
  
  + F6.l H(String) → q
  + G6.q <init>(I0)
  + G6.q b(l, s) → List
  + G6.q c(j, List) → boolean
  + G6.q d(j, l, List, boolean) → a
  + G6.q e(boolean) → a
  + G6.q f(j, List) → h
  + G6.q h(j, l, List, s) → List
  + G6.q j() → h
  + G6.r <clinit>()
  + G6.r a() → t1
  + G6.r b(boolean) → Set
  + G6.r c() → boolean
  + G6.r d() → v
  + G6.r e(l) → boolean
  
  - F6.l H(String) → r
  - G6.P <clinit>()
  - G6.P a() → t1
  - G6.P b(boolean) → Set
  - G6.P c() → boolean
  - G6.P d() → v
  - G6.P e(l) → boolean
  - G6.q <clinit>()
  - G6.q a() → t1
  - G6.q b(boolean) → Set
  - G6.q c() → boolean
  - G6.q d() → v
  - G6.q e(l) → boolean
  - G6.r <init>(I0)
  - G6.r b(l, s) → List
  - G6.r c(j, List) → boolean
  - G6.r d(j, l, List, boolean) → a
  - G6.r e(boolean) → a
  - G6.r f(j, List) → h
  - G6.r h(j, l, List, s) → List
  - G6.r j() → h
  

FIELDS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   39810 │ 39806 │ -4 (+7 -11) 
  
  + G6.G c: boolean
  + G6.M c: boolean
  + G6.q a: I0
  + G6.r a: r
  + G6.r b: t1
  + K6.t1 U: t1[]
  + K6.t1 V: b
  
  - G6.H c: boolean
  - G6.N c: boolean
  - G6.P a: P
  - G6.P b: t1
  - G6.b E: b
  - G6.q a: q
  - G6.q b: t1
  - G6.r a: I0
  - K6.t1 U: t1
  - K6.t1 V: t1[]
  - K6.t1 W: b
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6209 │ 6207 │ -2 (+0 -2) 
  - drawable/stripe_ic_paymentsheet_pm_crypto
  - string/stripe_paymentsheet_payment_method_crypto

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review December 23, 2024 13:09
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners December 23, 2024 13:09
@jaynewstrom-stripe
Copy link
Collaborator Author

cc @ericzhang-stripe

@jaynewstrom-stripe jaynewstrom-stripe merged commit b846637 into master Dec 23, 2024
16 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/remove-ps-crypto branch December 23, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants