Fix color support for Windows 10 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stripe-ci
assigned ob-stripe and unassigned brandur-stripe, tomer-stripe and aarongreen-stripe
|
Released as v0.4.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @brandur-stripe @aarongreen-stripe @tomer-stripe
cc @stripe/dev-platform
Summary
The Windows console does not support ANSI color codes, resulting in strange characters in the output (cf. #93). With Windows 10, the console can support ANSI colors, but support must be explicitly enabled.
This PR does that by using some code adapted from this comment: sirupsen/logrus#496 (comment).
It also changes the spinner charset to use standard ASCII characters on Windows, since the default console font does not support the fancy characters.
Fixes #93 (to an extent).