Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send CBC preferred network in confirm call #2965

Merged
merged 11 commits into from
Oct 4, 2023

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented Oct 2, 2023

Summary

  • We now send card[networks][preferred] the network call when confirming a CBC intent
  • When no card brand is selected we omit networks from card params entirley.

Motivation

https://docs.google.com/document/d/1T12LgVTkEv-LaDtQO3lGgNDt3nV_mwrUOJWgfUmTa9U/edit

Testing

  • New unit tests
  • Manual

Changelog

See diff

@@ -254,7 +254,10 @@ extension DropdownFieldElement: PickerFieldViewDelegate {
didUpdate?(selectedIndex)
}
previouslySelectedIndex = selectedIndex
delegate?.continueToNextField(element: self)
DispatchQueue.main.async { [weak self] in
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes a bug I was seeing and #2936

@porter-stripe porter-stripe marked this pull request as ready for review October 2, 2023 20:38
@porter-stripe porter-stripe requested review from a team as code owners October 2, 2023 20:38
@porter-stripe porter-stripe merged commit b5ea455 into master Oct 4, 2023
1 check passed
@porter-stripe porter-stripe deleted the porter/send-cbc-selected branch October 4, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants