Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DefaultSPM flag and conditionally rendered card details label and default checkbox #4266

Closed
wants to merge 13 commits into from

Conversation

joyceqin-stripe
Copy link
Collaborator

Summary

Motivation

Testing

Changelog

Copy link

github-actions bot commented Nov 13, 2024

⚠️ Missing Translations
The following strings have been uploaded to Lokalise but are not yet translated.

Card details cannot be changed., Manage card, Your card has expired.

If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label ship without translations to acknowledge that there are missing translations. Otherwise, wait until translations are available in Lokalise and re-run this job.

New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link.

Copy link

github-actions bot commented Nov 14, 2024

🚨 New dead code detected in this PR:

String+Localized.swift:118 warning: Property 'update' is unused
CustomerSavedPaymentMethodsCollectionViewController.swift:85 warning: Property 'defaultSPMNavigation' is assigned, but never used

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

@joyceqin-stripe joyceqin-stripe changed the title Added DefaultSPMFlag and conditionally rendered card details label Added DefaultSPM flag and conditionally rendered card details label and default checkbox Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant