Remove payment_method_creation from types (#530)

stripe · Dec 11, 2023 · 31b50b6 · 31b50b6
1 parent 0309bef
commit 31b50b6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/tests/types/src/invalid.ts b/tests/types/src/invalid.ts
@@ -15,8 +15,12 @@ declare const paymentElement: StripePaymentElement;
 declare const cartElement: StripeCartElement;
 declare const expressCheckoutElement: StripeExpressCheckoutElement;
 
-// @ts-expect-error: Passing `clientSecret` or `mode` implies different integration paths which cannot be combined
-const options: StripeElementsOptions = {clientSecret: '', mode: ''};
+const options: StripeElementsOptions = {
+  clientSecret: '',
+  // @ts-expect-error Type 'string' is not assignable to type '"payment" | "setup" | "subscription" | undefined'.ts(2322)
+  mode: '',
+  payment_method_creation: 'manual',
+};
 
 // @ts-expect-error: Passing `clientSecret` or `mode` implies different integration paths which cannot be combined
 const elements = stripe.elements(options);

diff --git a/tests/types/src/valid.ts b/tests/types/src/valid.ts
@@ -121,7 +121,6 @@ stripe.elements({
   setup_future_usage: 'off_session',
   capture_method: 'automatic',
   payment_method_types: ['card'],
-  payment_method_creation: 'manual',
   payment_method_options: {
     us_bank_account: {financial_connections: {permissions: ['payment_method']}},
   },

diff --git a/types/stripe-js/elements-group.d.ts b/types/stripe-js/elements-group.d.ts
@@ -778,11 +778,6 @@ export interface StripeElementsOptionsMode extends BaseStripeElementsOptions {
    */
   paymentMethodCreation?: 'manual';
 
-  /**
-   * Allows PaymentMethods to be created from the Elements instance.
-   */
-  payment_method_creation?: 'manual';
-
   /**
    * Additional payment-method-specific options for configuring Payment Element behavior.
    *