Flexible AdditionalProperties
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we only ever had the boolean use of `AdditionalProperties`,
in that a `false` was used to specify that no additional properties were
allowed.
As of more recent versions of the spec, we're now using the schema
format for it as well, and this causes the YAML parser to error as it
encounters a value that's not compatible with the `bool` that we had
specified before.
This patch changes `AdditionalProperties` to take an `interface{}` so
that either type can be accepted. This won't be workable if we actually
need a value for `AdditionalProperties`, but we're not using this
property at the moment, so it's fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only ever had the boolean use of
AdditionalProperties,in that a
falsewas used to specify that no additional properties wereallowed.
As of more recent versions of the spec, we're now using the schema
format for it as well, and this causes the YAML parser to error as it
encounters a value that's not compatible with the
boolthat we hadspecified before.
This patch changes
AdditionalPropertiesto take aninterface{}sothat either type can be accepted. This won't be workable if we actually
need a value for
AdditionalProperties, but we're not using thisproperty at the moment, so it's fine for now.