Properly handle API errors with unknown error types (#1357)

stripe · Feb 26, 2022 · 2a1a35b · 2a1a35b
1 parent 57736db
commit 2a1a35b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/Error.js b/lib/Error.js
@@ -49,7 +49,7 @@ class StripeError extends Error {
       case 'invalid_grant':
         return new StripeInvalidGrantError(rawStripeError);
       default:
-        return new GenericError('Generic', 'Unknown Error');
+        return new StripeUnknownError(rawStripeError);
     }
   }
 }
@@ -122,6 +122,11 @@ class StripeIdempotencyError extends StripeError {}
  */
 class StripeInvalidGrantError extends StripeError {}
 
+/**
+ * Any other error from Stripe not specifically captured above
+ */
+class StripeUnknownError extends StripeError {}
+
 module.exports.generate = StripeError.generate;
 module.exports.StripeError = StripeError;
 module.exports.StripeCardError = StripeCardError;
@@ -134,3 +139,4 @@ module.exports.StripeConnectionError = StripeConnectionError;
 module.exports.StripeSignatureVerificationError = StripeSignatureVerificationError;
 module.exports.StripeIdempotencyError = StripeIdempotencyError;
 module.exports.StripeInvalidGrantError = StripeInvalidGrantError;
+module.exports.StripeUnknownError = StripeUnknownError;
diff --git a/test/Error.spec.js b/test/Error.spec.js
@@ -20,6 +20,9 @@ describe('Error', () => {
       expect(
         Error.StripeError.generate({type: 'idempotency_error'})
       ).to.be.instanceOf(Error.StripeIdempotencyError);
+      expect(
+        Error.StripeError.generate({type: 'weird_error'})
+      ).to.be.instanceOf(Error.StripeUnknownError);
     });
 
     it('copies whitelisted properties', () => {