Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow monkey patching http / https #1866

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

anniel-stripe
Copy link
Contributor

@anniel-stripe anniel-stripe commented Aug 2, 2023

Achieves a similar affect as #1854 (but without turning on the esModuleInterop option) to enable monkey patching of the 'http' / 'https' modules when importing stripe as an ES module.

Also adds a test to prevent against future regressions, and makes esModuleInterop: false explicit.

Motivation: #1844

Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some suggestions about comments.

src/net/NodeHttpClient.ts Outdated Show resolved Hide resolved
src/net/NodeHttpClient.ts Show resolved Hide resolved
tsconfig.cjs.json Show resolved Hide resolved
@anniel-stripe anniel-stripe merged commit 847a024 into master Aug 2, 2023
7 checks passed
@anniel-stripe anniel-stripe deleted the anniel-monkey-patchable-http branch August 2, 2023 19:59
stripe-openapi bot added a commit that referenced this pull request Aug 3, 2023
* Update generated code for v434

* Update generated code for v435

* Update generated code for v436

* Update generated code for v437

* Update generated code for v438

* Allow monkey patching http / https (#1866)

* allow monkey-patching http / https in ESM context

* comment in tscsonfig

* better comment

* Update generated code for v441

* Update generated code for v442

* Update generated code for v443

* Update generated code for v444

* Update generated code for v444

* Update generated code for v445

* Update generated code for v446

---------

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: anniel-stripe <97691964+anniel-stripe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants